Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Package Versions Bump] Updating package versions #6150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Test Package Versions Bump] Updating package versions #6150

wants to merge 1 commit into from
+599 −473

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners October 13, 2024 00:23
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 13, 2024 •
edited
Loading

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 23c8d32
Test service: dd-trace-dotnet

✅ 0 Failed, 365998 Passed, 2069 Skipped, 14h 57m 18.49s Total Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6150) - mean (70ms)  : 67, 72
     .   : milestone, 70,
    master - mean (70ms)  : 67, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6150) - mean (1,108ms)  : 1087, 1129
     .   : milestone, 1108,
    master - mean (1,108ms)  : 1080, 1136
     .   : milestone, 1108,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6150) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 104, 112
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6150) - mean (766ms)  : 751, 780
     .   : milestone, 766,
    master - mean (769ms)  : 752, 785
     .   : milestone, 769,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6150) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6150) - mean (725ms)  : 710, 741
     .   : milestone, 725,
    master - mean (728ms)  : 709, 747
     .   : milestone, 728,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6150) - mean (190ms)  : 185, 194
     .   : milestone, 190,
    master - mean (190ms)  : 185, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6150) - mean (1,196ms)  : 1163, 1228
     .   : milestone, 1196,
    master - mean (1,204ms)  : 1140, 1268
     .   : milestone, 1204,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6150) - mean (274ms)  : 269, 279
     .   : milestone, 274,
    master - mean (273ms)  : 269, 278
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (6150) - mean (940ms)  : 922, 958
     .   : milestone, 940,
    master - mean (949ms)  : 885, 1013
     .   : milestone, 949,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6150) - mean (263ms)  : 258, 267
     .   : milestone, 263,
    master - mean (263ms)  : 260, 266
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (6150) - mean (927ms)  : 910, 944
     .   : milestone, 927,
    master - mean (927ms)  : 886, 968
     .   : milestone, 927,
Loading

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6150) (11.050M)   : 0, 11050269
    master (10.843M)   : 0, 10843149
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6150) (7.246M)   : 0, 7245575
    master (7.342M)   : 0, 7341616
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.634M)   : 0, 7634119

    section Manual
    master (11.123M)   : 0, 11122612

    section Manual + Automatic
    This PR (6150) (6.576M)   : 0, 6575801
    master (6.799M)   : 0, 6798648

    section DD_TRACE_ENABLED=0
    master (10.102M)   : 0, 10101842
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6150) (9.466M)   : 0, 9466017
    master (9.552M)   : 0, 9552299
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6150) (6.475M)   : 0, 6474626
    master (6.487M)   : 0, 6487385

    section Trace stats
    master (6.716M)   : 0, 6716401

    section Manual
    master (9.598M)   : 0, 9597549

    section Manual + Automatic
    This PR (6150) (6.105M)   : 0, 6104827
    master (6.054M)   : 0, 6054137

    section DD_TRACE_ENABLED=0
    master (8.805M)   : 0, 8804584
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6150) (10.046M)   : 0, 10046358
    master (10.046M)   : 0, 10046278
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6150) (6.784M)   : 0, 6784123
    master (6.846M)   : 0, 6845566
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.374M)   : 0, 7373747

    section Manual
    master (9.936M)   : 0, 9936111

    section Manual + Automatic
    This PR (6150) (6.165M)   : 0, 6164692
    master (6.408M)   : 0, 6407704

    section DD_TRACE_ENABLED=0
    master (9.479M)   : 0, 9478997
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6150 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.208
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.77μs 43.2ns 263ns 0.016 0.00802 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.83μs 55.1ns 366ns 0.0235 0.00939 0 5.62 KB
master StartStopWithChild net472 16.6μs 58.6ns 211ns 1.02 0.302 0.0923 6.06 KB
#6150 StartStopWithChild net6.0 7.59μs 42.4ns 285ns 0.0142 0.00356 0 5.42 KB
#6150 StartStopWithChild netcoreapp3.1 10.1μs 54.5ns 299ns 0.0147 0.00491 0 5.62 KB
#6150 StartStopWithChild net472 16.5μs 63.2ns 245ns 1.03 0.32 0.0902 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 470μs 388ns 1.45μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 646μs 631ns 2.44μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 843μs 660ns 2.47μs 0.417 0 0 3.3 KB
#6150 WriteAndFlushEnrichedTraces net6.0 459μs 264ns 1.02μs 0 0 0 2.7 KB
#6150 WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 349ns 1.35μs 0 0 0 2.7 KB
#6150 WriteAndFlushEnrichedTraces net472 855μs 442ns 1.71μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 205μs 1.17μs 8.79μs 0.189 0 0 18.45 KB
master SendRequest netcoreapp3.1 231μs 1.12μs 4.6μs 0.236 0 0 20.61 KB
master SendRequest net472 0.00302ns 0.0013ns 0.00504ns 0 0 0 0 b
#6150 SendRequest net6.0 204μs 1.18μs 9.69μs 0.215 0 0 18.45 KB
#6150 SendRequest netcoreapp3.1 221μs 1.27μs 9.49μs 0.238 0 0 20.61 KB
#6150 SendRequest net472 0.0012ns 0.000536ns 0.00208ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6150

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.87 KB 41.64 KB -224 B -0.54%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 587μs 2.94μs 14.1μs 0.59 0 0 41.45 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 708μs 3.71μs 28.2μs 0.365 0 0 41.87 KB
master WriteAndFlushEnrichedTraces net472 880μs 4.51μs 20.2μs 8.25 2.6 0.434 53.29 KB
#6150 WriteAndFlushEnrichedTraces net6.0 555μs 1.99μs 7.45μs 0.573 0 0 41.57 KB
#6150 WriteAndFlushEnrichedTraces netcoreapp3.1 768μs 4.2μs 23.8μs 0.363 0 0 41.64 KB
#6150 WriteAndFlushEnrichedTraces net472 857μs 3.11μs 12μs 8.08 2.55 0.425 53.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.28μs 1.77ns 6.86ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.8μs 2.21ns 8.57ns 0.0134 0 0 1.02 KB
master ExecuteNonQuery net472 2.05μs 1.25ns 4.32ns 0.157 0 0 987 B
#6150 ExecuteNonQuery net6.0 1.2μs 1.87ns 7.24ns 0.0144 0 0 1.02 KB
#6150 ExecuteNonQuery netcoreapp3.1 1.76μs 1.3ns 4.85ns 0.0132 0 0 1.02 KB
#6150 ExecuteNonQuery net472 2.05μs 1.83ns 6.86ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.29μs 0.722ns 2.79ns 0.0133 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.62μs 1.32ns 5.11ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.59μs 1.11ns 4.29ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.31μs 1.31ns 4.88ns 0.013 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.61μs 0.831ns 3.22ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.63μs 0.907ns 3.39ns 0.166 0 0 1.05 KB
#6150 CallElasticsearch net6.0 1.19μs 0.733ns 2.74ns 0.0137 0 0 976 B
#6150 CallElasticsearch netcoreapp3.1 1.51μs 1.05ns 3.92ns 0.0136 0 0 976 B
#6150 CallElasticsearch net472 2.58μs 2.71ns 10.5ns 0.157 0 0 995 B
#6150 CallElasticsearchAsync net6.0 1.18μs 0.469ns 1.75ns 0.0132 0 0 952 B
#6150 CallElasticsearchAsync netcoreapp3.1 1.72μs 0.798ns 2.99ns 0.013 0 0 1.02 KB
#6150 CallElasticsearchAsync net472 2.64μs 1.29ns 5.01ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.3μs 0.756ns 2.93ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.62μs 0.926ns 3.59ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.7μs 0.525ns 2.03ns 0.145 0 0 915 B
#6150 ExecuteAsync net6.0 1.34μs 1.19ns 4.45ns 0.0134 0 0 952 B
#6150 ExecuteAsync netcoreapp3.1 1.53μs 0.479ns 1.79ns 0.0129 0 0 952 B
#6150 ExecuteAsync net472 1.89μs 0.795ns 2.97ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.15μs 1.54ns 5.96ns 0.0306 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.06μs 1.62ns 6.08ns 0.038 0 0 2.76 KB
master SendAsync net472 7.84μs 1.93ns 7.47ns 0.496 0 0 3.15 KB
#6150 SendAsync net6.0 4.12μs 0.796ns 3.08ns 0.0308 0 0 2.22 KB
#6150 SendAsync netcoreapp3.1 5.02μs 2.13ns 8.24ns 0.0356 0 0 2.76 KB
#6150 SendAsync net472 7.84μs 3.75ns 14.5ns 0.497 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.6μs 3.84ns 14.9ns 0.0226 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.21μs 1.38ns 5.35ns 0.0224 0 0 1.64 KB
master EnrichedLog net472 2.6μs 0.842ns 3.15ns 0.249 0 0 1.57 KB
#6150 EnrichedLog net6.0 1.47μs 2.8ns 10.1ns 0.0226 0 0 1.64 KB
#6150 EnrichedLog netcoreapp3.1 2.25μs 1.5ns 5.6ns 0.0218 0 0 1.64 KB
#6150 EnrichedLog net472 2.57μs 2.34ns 9.07ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 122ns 472ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 149ns 578ns 0 0 0 4.28 KB
master EnrichedLog net472 153μs 178ns 689ns 0.689 0.23 0 4.46 KB
#6150 EnrichedLog net6.0 117μs 176ns 683ns 0.058 0 0 4.28 KB
#6150 EnrichedLog netcoreapp3.1 121μs 127ns 459ns 0.0605 0 0 4.28 KB
#6150 EnrichedLog net472 151μs 340ns 1.32μs 0.688 0.229 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3μs 1.14ns 4.41ns 0.0303 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.34μs 1.01ns 3.66ns 0.0303 0 0 2.2 KB
master EnrichedLog net472 4.76μs 1.18ns 4.57ns 0.319 0 0 2.02 KB
#6150 EnrichedLog net6.0 3.18μs 0.838ns 3.02ns 0.0303 0 0 2.2 KB
#6150 EnrichedLog netcoreapp3.1 4.27μs 3.89ns 15.1ns 0.0298 0 0 2.2 KB
#6150 EnrichedLog net472 5.06μs 1.33ns 5.16ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.41μs 0.704ns 2.73ns 0.0161 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.65μs 0.917ns 3.55ns 0.0149 0 0 1.14 KB
master SendReceive net472 2.12μs 1.86ns 7.21ns 0.183 0 0 1.16 KB
#6150 SendReceive net6.0 1.27μs 0.641ns 2.4ns 0.0158 0 0 1.14 KB
#6150 SendReceive netcoreapp3.1 1.8μs 1.44ns 5.58ns 0.0152 0 0 1.14 KB
#6150 SendReceive net472 2.1μs 0.909ns 3.4ns 0.183 0.00107 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.88μs 1.22ns 4.74ns 0.0215 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.82μs 2.51ns 9.74ns 0.021 0 0 1.65 KB
master EnrichedLog net472 4.5μs 1.34ns 5.02ns 0.322 0 0 2.04 KB
#6150 EnrichedLog net6.0 2.76μs 2.94ns 11ns 0.0221 0 0 1.6 KB
#6150 EnrichedLog netcoreapp3.1 3.85μs 1.9ns 7.35ns 0.0213 0 0 1.65 KB
#6150 EnrichedLog net472 4.3μs 1.87ns 7.23ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6150

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.208 669.36 554.30

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 427ns 0.264ns 1.02ns 0.00812 0 0 576 B
master StartFinishSpan netcoreapp3.1 668ns 1.34ns 5.19ns 0.008 0 0 576 B
master StartFinishSpan net472 702ns 0.724ns 2.8ns 0.0916 0 0 578 B
master StartFinishScope net6.0 546ns 0.388ns 1.5ns 0.00967 0 0 696 B
master StartFinishScope netcoreapp3.1 769ns 0.367ns 1.42ns 0.00924 0 0 696 B
master StartFinishScope net472 947ns 1.02ns 3.97ns 0.104 0 0 658 B
#6150 StartFinishSpan net6.0 404ns 0.157ns 0.588ns 0.00812 0 0 576 B
#6150 StartFinishSpan netcoreapp3.1 554ns 0.257ns 0.962ns 0.00783 0 0 576 B
#6150 StartFinishSpan net472 749ns 0.535ns 2.07ns 0.0915 0 0 578 B
#6150 StartFinishScope net6.0 548ns 0.156ns 0.582ns 0.00967 0 0 696 B
#6150 StartFinishScope netcoreapp3.1 715ns 0.392ns 1.52ns 0.00964 0 0 696 B
#6150 StartFinishScope net472 888ns 0.66ns 2.56ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 723ns 1.03ns 3.98ns 0.00987 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1μs 0.494ns 1.91ns 0.00903 0 0 696 B
master RunOnMethodBegin net472 1.2μs 1.44ns 5.59ns 0.104 0 0 658 B
#6150 RunOnMethodBegin net6.0 729ns 0.622ns 2.41ns 0.00983 0 0 696 B
#6150 RunOnMethodBegin netcoreapp3.1 934ns 1.09ns 4.07ns 0.00932 0 0 696 B
#6150 RunOnMethodBegin net472 1.13μs 0.335ns 1.3ns 0.104 0 0 658 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewlock