Build against macos-13 as macos-12 is going to be deprecated #6138
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
the
area:builds
andrewlock
force-pushed
the
andrew/ci/build-against-macos-13
branch
from
07025e1
to
8ff0c25
Compare
Datadog ReportBranch report: ✅ 0 Failed, 365895 Passed, 2072 Skipped, 15h 4m 28.54s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6138) - mean (70ms) : 67, 73
. : milestone, 70,
master - mean (70ms) : 67, 72
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6138) - mean (1,112ms) : 1091, 1133
. : milestone, 1112,
master - mean (1,110ms) : 1085, 1135
. : milestone, 1110,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6138) - mean (108ms) : 105, 111
. : milestone, 108,
master - mean (109ms) : 105, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6138) - mean (770ms) : 753, 788
. : milestone, 770,
master - mean (771ms) : 757, 786
. : milestone, 771,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6138) - mean (92ms) : 89, 94
. : milestone, 92,
master - mean (92ms) : 89, 95
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6138) - mean (725ms) : 710, 740
. : milestone, 725,
master - mean (727ms) : 710, 744
. : milestone, 727,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6138) - mean (189ms) : 187, 191
. : milestone, 189,
master - mean (189ms) : 186, 192
. : milestone, 189,
section CallTarget+Inlining+NGEN
This PR (6138) - mean (1,199ms) : 1170, 1227
. : milestone, 1199,
master - mean (1,201ms) : 1179, 1222
. : milestone, 1201,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6138) - mean (275ms) : 270, 280
. : milestone, 275,
master - mean (274ms) : 269, 278
. : milestone, 274,
section CallTarget+Inlining+NGEN
This PR (6138) - mean (944ms) : 923, 965
. : milestone, 944,
master - mean (943ms) : 926, 960
. : milestone, 943,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6138) - mean (263ms) : 259, 267
. : milestone, 263,
master - mean (263ms) : 259, 267
. : milestone, 263,
section CallTarget+Inlining+NGEN
This PR (6138) - mean (925ms) : 906, 944
. : milestone, 925,
master - mean (924ms) : 908, 940
. : milestone, 924,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6138) (11.120M) : 0, 11120157
master (11.252M) : 0, 11251784
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6138) (7.201M) : 0, 7201220
master (7.466M) : 0, 7465753
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.766M) : 0, 7765791
section Manual
master (11.114M) : 0, 11114354
section Manual + Automatic
This PR (6138) (6.756M) : 0, 6756054
master (6.846M) : 0, 6845872
section DD_TRACE_ENABLED=0
master (10.389M) : 0, 10388612
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6138) (9.226M) : 0, 9226094
master (9.539M) : 0, 9539093
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6138) (6.341M) : 0, 6341081
master (6.648M) : 0, 6647799
section Trace stats
master (6.855M) : 0, 6855301
section Manual
master (9.525M) : 0, 9525425
section Manual + Automatic
This PR (6138) (6.059M) : 0, 6058946
master (6.161M) : 0, 6160600
section DD_TRACE_ENABLED=0
master (8.832M) : 0, 8832117
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6138) (10.064M) : 0, 10063739
master (10.064M) : 0, 10064242
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6138) (6.981M) : 0, 6980760
master (6.841M) : 0, 6841333
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.427M) : 0, 7426854
section Manual
master (10.084M) : 0, 10084210
section Manual + Automatic
This PR (6138) (6.480M) : 0, 6480240
master (6.348M) : 0, 6347556
section DD_TRACE_ENABLED=0
master (9.577M) : 0, 9576577
|
Benchmarks Report for tracer 🐌Benchmarks for #6138 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 | 1.135 | 655.37 | 577.42 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 404ns | 0.213ns | 0.824ns | 0.0081 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 655ns | 0.38ns | 1.47ns | 0.00786 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 701ns | 0.453ns | 1.7ns | 0.0917 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 485ns | 0.239ns | 0.924ns | 0.00976 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 758ns | 0.391ns | 1.46ns | 0.00957 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 873ns | 0.405ns | 1.57ns | 0.104 | 0 | 0 | 658 B |
| #6138 | StartFinishSpan |
net6.0 | 402ns | 0.306ns | 1.19ns | 0.0081 | 0 | 0 | 576 B |
| #6138 | StartFinishSpan |
netcoreapp3.1 | 578ns | 0.495ns | 1.79ns | 0.00773 | 0 | 0 | 576 B |
| #6138 | StartFinishSpan |
net472 | 744ns | 0.431ns | 1.67ns | 0.0917 | 0 | 0 | 578 B |
| #6138 | StartFinishScope |
net6.0 | 522ns | 0.325ns | 1.26ns | 0.00978 | 0 | 0 | 696 B |
| #6138 | StartFinishScope |
netcoreapp3.1 | 794ns | 0.203ns | 0.787ns | 0.00953 | 0 | 0 | 696 B |
| #6138 | StartFinishScope |
net472 | 958ns | 1.95ns | 7.55ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 671ns | 0.323ns | 1.25ns | 0.00977 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 974ns | 1.03ns | 3.84ns | 0.0092 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.16μs | 0.465ns | 1.8ns | 0.104 | 0 | 0 | 658 B |
| #6138 | RunOnMethodBegin |
net6.0 | 644ns | 0.325ns | 1.22ns | 0.00976 | 0 | 0 | 696 B |
| #6138 | RunOnMethodBegin |
netcoreapp3.1 | 977ns | 0.62ns | 2.4ns | 0.00937 | 0 | 0 | 696 B |
| #6138 | RunOnMethodBegin |
net472 | 1.13μs | 0.989ns | 3.83ns | 0.105 | 0 | 0 | 658 B |
andrewlock
force-pushed
the
andrew/ci/build-against-macos-13
branch
from
8ff0c25
to
be163d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes CI to build using macos-13 instead of macos-12
Reason for change
Azure Devops are removing macos-12 images and will start running brownouts from November, so we have to update.
Implementation details
macos-12->macos-13Test coverage
This is the test - I will also do a full installer tests run