RUM-7937 [SR] Use Deterministic Random Wireframe ID #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
force-pushed
the
maxep/RUM-7937/fix-duplicated-swiftui-wireframe-id
branch
from
fa20614 to
f763e63
Compare
Datadog ReportBranch report: ✅ 0 Failed, 14 Passed, 3624 Skipped, 18.31s Total duration (2m 9.54s time saved) |
maciejburda
approved these changes
Jan 9, 2025
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Session Replay of SwiftUI is generating staling views in replays, this is due to duplicate wireframe IDs between UIKit recorder and SwiftUI. UIKit recorders use incremental wireframe ids while SwiftUI is based on a
seedvalue of the content, these value can overlap and create duplicates.How?
To avoid overlaps, we now use a seeded random generator to generate deterministic IDs base of the content's
seedvalue.The deterministic generator implements the xoshiro256** generator for its speed and low memory footprint.
Review checklist
make api-surface)