[CTK-4365] [CTK-4612] [CTK-4612] Update tests to look at all possible payloads to look for valid processes instead of just the first 2 #33642
+67
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assertEventually. Also introduce more granular error logging.
…d processes instead of just the first 2. This is to reduce flakiness of the tests.
…d processes instead of just the first 2. This is to reduce flakiness of the tests.
wiyu
added
changelog/no-changelog
qa/no-code-change
github-actions
bot
added
the
short review
wiyu
commented
Jan 31, 2025
| @@ -136,6 +185,17 @@ func findProcess( | |||
| return found, populated | |||
| } | |||
|
|
|||
| // filterProcesses returns processes which match the given process name | |||
There was a problem hiding this comment.
I broke this out from findProcess() as to allow for better logging of when we don't find cpu/memory data from the processes. When we are missing that data we can just log the processes we found instead of all payloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the payload assertions into the assertEventually that way we can capture up to 2 minutes worth of payloads instead of just the first 2. This is to reduce flakiness in case the cpu-stress processes do not show cpu load on the first 2 initial payloads due to startup.
This updates the ECSEC2 test and the Docker Process Check. If this doesn't flake as much, then we can convert all tests to follow this method of assertion.
Motivation
Reduce test flakes
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes