Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default for process checks in core agent #33434

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

change default for process checks in core agent #33434

wants to merge 6 commits into from

Conversation

brycekahle
Copy link
Member

@brycekahle brycekahle commented Jan 27, 2025 •
edited
Loading

What does this PR do?

Changes the default value of process_config.run_in_core_agent.enabled so process checks run in the core agent on Linux by default.

Motivation

Reducing the total agent RSS by avoiding the process-agent process where possible.

Describe how you validated your changes

Updated existing tests.

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/container-intake fka Processes labels Jan 27, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 27, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor 2d57ceaa0130a38de62b7db2081888917610047c

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 0.00MB ✅ 456.45MB 456.44MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 89.89MB 89.89MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 89.96MB 89.96MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 93.90MB 93.90MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 93.90MB 93.90MB 0.50MB
datadog-agent-amd64-deb 0.00MB ✅ 877.18MB 877.18MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB ✅ 886.92MB 886.92MB 0.50MB
datadog-agent-x86_64-suse 0.00MB ✅ 886.92MB 886.92MB 0.50MB
datadog-agent-arm64-deb 0.00MB ✅ 864.97MB 864.97MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB ✅ 874.69MB 874.69MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 59.02MB 59.02MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 56.50MB 56.50MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 93.83MB 93.83MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 27, 2025 •
edited
Loading

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54636894 --os-family=ubuntu

Note: This applies to commit 0bdada9

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jan 27, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c4f0f071-1a63-429c-8170-26e2d53301f1

Baseline: 2d57cea
Comparison: 0bdada9
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
✅ file_tree memory utilization -9.76 [-9.82, -9.69] 1 Logs
✅ quality_gate_idle memory utilization -19.43 [-19.49, -19.37] 1 Logs bounds checks dashboard

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_idle_all_features memory utilization +0.97 [+0.90, +1.04] 1 Logs bounds checks dashboard
➖ tcp_syslog_to_blackhole ingress throughput +0.75 [+0.68, +0.81] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.09 [-0.70, +0.87] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.82, +0.86] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.29] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.00 [-0.64, +0.63] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.02 [-0.71, +0.68] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.88, +0.84] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.02 [-0.92, +0.87] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.30 [-0.76, +0.16] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.31 [-1.10, +0.47] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.69 [-1.55, +0.18] 1 Logs
➖ quality_gate_logs % cpu utilization -4.02 [-7.05, -0.98] 1 Logs
✅ file_tree memory utilization -9.76 [-9.82, -9.69] 1 Logs
✅ quality_gate_idle memory utilization -19.43 [-19.49, -19.37] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 30, 2025
@brycekahle brycekahle added the qa/done QA done before merge and regressions are covered by tests label Jan 31, 2025
@brycekahle brycekahle force-pushed the bryce.kahle/process-agent-in-core branch from accadef to 41c55d9 Compare January 31, 2025 19:28
@brycekahle brycekahle added this to the 7.64.0 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/container-intake fka Processes
Projects
None yet
Milestone
7.64.0
Development

Successfully merging this pull request may close these issues.
1 participant
@brycekahle