Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[AMLII-2183] Logs From Integrations Rotation E2E Test and Yam… #32492

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Revert "[AMLII-2183] Logs From Integrations Rotation E2E Test and Yam… #32492

merged 1 commit into from
Dec 23, 2024

Conversation

chouquette
Copy link
Contributor

What does this PR do?

Revert changes introduced in #31812

Motivation

#incident-33564

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@chouquette
Revert "[AMLII-2183] Logs From Integrations Rotation E2E Test and Yam…
edf7ca1 
…l Template (#31812)"

This reverts commit 5bd602d.
Related to #incident-33564
@chouquette chouquette added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 23, 2024
@chouquette chouquette requested a review from a team as a code owner December 23, 2024 21:47
@github-actions github-actions bot added the medium review PR review might take time label Dec 23, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51750611 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51750611 --os-family=ubuntu

Note: This applies to commit edf7ca1

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor d3df21f211f883e7ed4378dc5409371d2824bb32

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB ✅ 1189.00MB 1189.00MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB ✅ 1198.27MB 1198.27MB 140.00MB
datadog-agent-x86_64-suse 0.00MB ✅ 1198.27MB 1198.27MB 140.00MB
datadog-agent-arm64-deb 0.00MB ✅ 934.94MB 934.94MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB ✅ 944.18MB 944.18MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 55.77MB 55.77MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 505.09MB 505.09MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 113.35MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 113.42MB 113.42MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 108.88MB 108.88MB 10.00MB

Decision

✅ Passed

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 235e2c1c-1496-44c2-841d-2618489640a8

Baseline: d3df21f
Comparison: edf7ca1
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ otel_to_otel_logs ingress throughput +1.14 [+0.46, +1.82] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.85 [+0.79, +0.91] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.23 [-0.23, +0.69] 1 Logs
➖ quality_gate_idle memory utilization +0.17 [+0.12, +0.21] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.15 [+0.06, +0.23] 1 Logs bounds checks dashboard
➖ file_to_blackhole_100ms_latency egress throughput +0.08 [-0.65, +0.81] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.08 [-0.56, +0.73] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.07 [-0.70, +0.84] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.06 [-0.85, +0.96] 1 Logs
➖ file_tree memory utilization +0.02 [-0.10, +0.14] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization +0.01 [-0.67, +0.69] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.86, +0.87] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.12, +0.12] 1 Logs
➖ quality_gate_logs % cpu utilization -0.04 [-3.27, +3.19] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.07 [-0.99, +0.85] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.35 [-1.12, +0.43] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@chouquette
Copy link
Contributor Author

Force merging to solve the incident

@chouquette chouquette merged commit cdf0a0a into main Dec 23, 2024
233 checks passed
@chouquette chouquette deleted the chouquette/incident_33564 branch December 23, 2024 22:53
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 23, 2024
louis-cqrl pushed a commit that referenced this pull request Dec 25, 2024
@chouquette @louis-cqrl
Revert "[AMLII-2183] Logs From Integrations Rotation E2E Test and Yam… (
df69240 
#32492)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Milestone
7.62.0
Development

Successfully merging this pull request may close these issues.
1 participant
@chouquette