Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump github.com/DataDog/nikos to v1.12.9 #32452

Merged
merged 1 commit into from
Dec 23, 2024
Merged

bump github.com/DataDog/nikos to v1.12.9 #32452

merged 1 commit into from
Dec 23, 2024

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

https://github.com/DataDog/nikos/releases/tag/v1.12.9, fixes an issue with latest version of rpmutils preventing some trivy related work.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@paulcacheux paulcacheux added the qa/done QA done before merge and regressions are covered by tests label Dec 23, 2024
@paulcacheux paulcacheux requested a review from a team as a code owner December 23, 2024 11:41
@github-actions github-actions bot added the medium review PR review might take time label Dec 23, 2024
@cit-pr-commenter cit-pr-commenter
Copy link

Go Package Import Differences

Baseline: e6c945e
Comparison: ba4cb87

binaryosarchchange
system-probelinuxamd64
+0, -6 
-golang.org/x/crypto/openpgp
-golang.org/x/crypto/openpgp/armor
-golang.org/x/crypto/openpgp/elgamal
-golang.org/x/crypto/openpgp/errors
-golang.org/x/crypto/openpgp/packet
-golang.org/x/crypto/openpgp/s2k
system-probelinuxarm64
+0, -6 
-golang.org/x/crypto/openpgp
-golang.org/x/crypto/openpgp/armor
-golang.org/x/crypto/openpgp/elgamal
-golang.org/x/crypto/openpgp/errors
-golang.org/x/crypto/openpgp/packet
-golang.org/x/crypto/openpgp/s2k

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor e6c945e2246e4144238c59dc5cb750311a783879

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB ✅ 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 55.77MB 55.77MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 108.80MB 108.80MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 108.87MB 108.87MB 10.00MB
datadog-heroku-agent-amd64-deb -0.00MB ✅ 504.88MB 504.88MB 70.00MB
datadog-agent-aarch64-rpm -0.15MB ✅ 943.00MB 943.15MB 140.00MB
datadog-agent-arm64-deb -0.15MB ✅ 933.75MB 933.90MB 140.00MB
datadog-agent-x86_64-rpm -0.19MB ✅ 1197.05MB 1197.24MB 140.00MB
datadog-agent-x86_64-suse -0.19MB ✅ 1197.05MB 1197.24MB 140.00MB
datadog-agent-amd64-deb -0.19MB ✅ 1187.78MB 1187.97MB 140.00MB

Decision

✅ Passed

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c5190d74-1366-412c-95ec-0c22ed99a0b5

Baseline: e6c945e
Comparison: ba4cb87
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +2.47 [-0.81, +5.75] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization +1.59 [+0.90, +2.28] 1 Logs
➖ otel_to_otel_logs ingress throughput +1.28 [+0.62, +1.95] 1 Logs
➖ quality_gate_idle memory utilization +0.28 [+0.24, +0.32] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.23 [+0.15, +0.31] 1 Logs bounds checks dashboard
➖ tcp_syslog_to_blackhole ingress throughput +0.13 [+0.07, +0.20] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.02 [-0.43, +0.48] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.02 [-0.66, +0.71] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.02 [-0.76, +0.79] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.65] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.00 [-0.89, +0.88] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.11] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.88, +0.86] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.91, +0.89] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.09 [-0.87, +0.69] 1 Logs
➖ file_tree memory utilization -0.32 [-0.45, -0.19] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@pducolin pducolin mentioned this pull request Dec 23, 2024
Merged
@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 23, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-23 15:51:00 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.

2024-12-23 16:27:10 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3982cbd into main Dec 23, 2024
433 of 436 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/bump-nikos-1.12.9 branch December 23, 2024 16:27
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 23, 2024
louis-cqrl pushed a commit that referenced this pull request Dec 25, 2024
@paulcacheux @louis-cqrl
bump github.com/DataDog/nikos to v1.12.9 (#32452)
576be71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pducolin pducolin pducolin approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Milestone
7.62.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paulcacheux @pducolin