[SBOM] Keep layer info in SBOM components #32435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebauce
added
changelog/no-changelog
team/agent-security
qa/rc-required
Go Package Import DifferencesBaseline: 3982cbd
|
lebauce
force-pushed
the
lebauce/trivy-sbom-layers
branch
from
7da1ad1 to
94636e8
Compare
github-actions
bot
added
component/system-probe
long review
lebauce
force-pushed
the
lebauce/trivy-sbom-layers
branch
3 times, most recently
from
2ebcefb to
aa87ba3
Compare
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=51753970 --os-family=ubuntuNote: This applies to commit 10f2df4 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 3982cbd Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +2.33 | [-0.95, +5.62] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +1.36 | [+1.32, +1.40] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.26 | [+0.57, +1.95] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.68 | [+0.60, +0.77] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.67 | [+0.54, +0.79] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.12 | [-0.80, +1.03] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.12 | [-0.62, +0.85] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.06 | [-0.78, +0.89] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.04 | [-0.77, +0.85] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.03 | [-0.75, +0.80] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.00 | [-0.64, +0.65] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.10, +0.10] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.08 | [-0.15, -0.00] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.08 | [-0.88, +0.72] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.34 | [-0.80, +0.12] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -0.52 | [-1.20, +0.16] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
chouetz
approved these changes
Dec 23, 2024
pducolin
approved these changes
Dec 23, 2024
lebauce
force-pushed
the
lebauce/trivy-sbom-layers
branch
from
1f98c1d to
dea78d9
Compare
paulcacheux
reviewed
Dec 23, 2024
lebauce
force-pushed
the
lebauce/trivy-sbom-layers
branch
from
36878b3 to
f92329a
Compare
paulcacheux
approved these changes
Dec 23, 2024
sblumenthal
approved these changes
Dec 23, 2024
go.mod
Outdated
Comment on lines
1084
to
1085
| // Maps to Trivy fork https://github.com/DataDog/trivy/commits/use-fs-main-dd/ | ||
| github.com/aquasecurity/trivy => github.com/DataDog/trivy v0.0.0-20241216135157-95e0e96002ee | ||
| github.com/aquasecurity/trivy => github.com/DataDog/trivy v0.0.0-20241223160824-d6db1f1a84ce |
There was a problem hiding this comment.
This comment doesn't appear to be correct, as it looks like this commit is coming from a different branch. Moreover, it looks like the new branch does not have a bunch of commits that were present in the previous branch, so just double checking that this is expected
There was a problem hiding this comment.
The comment is indeed incorrect. The new branch seems to be based on main of Trivy and includes a commit (DataDog/trivy@f11c14f) that bundles a bunch of commits. I did my best to check that we are not missing something here.
lebauce
force-pushed
the
lebauce/trivy-sbom-layers
branch
from
b65fa2f to
ea04a33
Compare
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the sbom.container_image.overlayfs_direct_scan mode to
keep the layers information attached to each component of the SBOM.
This PR also bump Trivy and uses a custom walker to implement
most of the features previously implemented in our Trivy fork.
Motivation
This allows to match vulnerabilities to the layer they are part of.
Describe how you validated your changes
Set
sbom.container_image.overlayfs_direct_scanin both host and containerized mode,for the docker, containerd and crio runtimes.
Possible Drawbacks / Trade-offs
Additional Notes