Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apm-trace-storage from the releasing teams #32418

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Dec 20, 2024

What does this PR do?

Remove apm-trace-storage from the releasing teams

Motivation

Discussed with Julien, they should not be there

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

I'm not sure this list is the best way to manage that. We should fix this

@FlorentClarret FlorentClarret requested review from a team as code owners December 20, 2024 12:22
@FlorentClarret FlorentClarret changed the title Remove apm-trace-storage to the releasing team Remove apm-trace-storage to the releasing teams Dec 20, 2024
@github-actions github-actions bot added team/agent-devx-loops team/agent-devx-infra short review PR is simple enough to be reviewed quickly labels Dec 20, 2024
@FlorentClarret FlorentClarret changed the title Remove apm-trace-storage to the releasing teams Remove apm-trace-storage from the releasing teams Dec 20, 2024
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 20, 2024
Copy link
Member

@KevinFairise2 KevinFairise2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point it might be easier to have a clear list of releasing teams rather than picking all the codeowners and removing the teams that do not care about the release

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51650029 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor c60d01f7db246bf3281245f37f7472f9692caee0

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.64MB 78.64MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.64MB 78.64MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.33MB 113.33MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.40MB 113.40MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.40MB 113.40MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.80MB 108.80MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.87MB 108.87MB 10.00MB
datadog-agent-x86_64-rpm -0.00MB 1197.23MB 1197.23MB 140.00MB
datadog-agent-x86_64-suse -0.00MB 1197.23MB 1197.23MB 140.00MB
datadog-agent-amd64-deb -0.01MB 1187.97MB 1187.97MB 140.00MB
datadog-agent-aarch64-rpm -1.40MB 943.21MB 944.60MB 140.00MB
datadog-agent-arm64-deb -1.40MB 933.97MB 935.36MB 140.00MB
datadog-heroku-agent-amd64-deb -1.40MB 504.87MB 506.28MB 70.00MB

Decision

✅ Passed

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2a388785-3029-4d78-9379-3d368a32764a

Baseline: c60d01f
Comparison: 2b38893
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +3.10 [-0.20, +6.39] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.22 [-0.47, +0.90] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.20 [-0.27, +0.67] 1 Logs
quality_gate_idle_all_features memory utilization +0.16 [+0.07, +0.24] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.12 [-0.72, +0.96] 1 Logs
otel_to_otel_logs ingress throughput +0.07 [-0.60, +0.73] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.07 [-0.58, +0.71] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.73, +0.81] 1 Logs
file_tree memory utilization +0.03 [-0.11, +0.16] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.85, +0.89] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.12, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.78, +0.71] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.11 [-0.99, +0.77] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.38 [-1.16, +0.40] 1 Logs
quality_gate_idle memory utilization -0.38 [-0.42, -0.34] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -2.32 [-2.41, -2.23] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http2 lost_bytes 8/10
file_to_blackhole_500ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 20, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-20 13:20:46 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 33m.


2024-12-20 13:54:00 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 395cb8e into main Dec 20, 2024
229 of 231 checks passed
@dd-mergequeue dd-mergequeue bot deleted the florentclarret/apm-trace-storage branch December 20, 2024 13:53
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx-infra team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants