[CONTINT-4416] Optimize KSM configmap collection #32368

ewoodthomas · 2024-12-18T21:50:55Z

What does this PR do?

Optimizes collection of configmaps for the configmap.count metric. Previously the entire configmap was collected (including the data and binarydata) fields. This PR uses the meta.k8s.io API to exclusively collect metadata for configmaps and only store name, namespace, UID, and resourceVersion. These are the only fields necessary to generate the configmap.count metric.

Motivation

Collection of configmaps can be quite expensive in terms of cpu/memory/network. The DCA requested and stored the entire configmap. By only querying and storing metadata, we massively reduce the costs of collecting configmaps.

Describe how you validated your changes

Deployed an agent with the changes
Deployed an agent without the changes
Deployed a massive amount of configmaps on both clusters using this script

#!/bin/bash

NUM_CONFIGMAPS=1000

DATA_SIZE_KB=100

NAMESPACE="configmap-test"

kubectl get namespace "$NAMESPACE" > /dev/null 2>&1 || kubectl create namespace "$NAMESPACE"

generate_large_data() {
  head -c "$((DATA_SIZE_KB * 1024))" /dev/urandom | base64 | tr -d '\n'
}

for i in $(seq 1 "$NUM_CONFIGMAPS"); do
  CONFIGMAP_NAME="large-configmap-$i"
  echo "Creating ConfigMap: $CONFIGMAP_NAME with ${DATA_SIZE_KB}KB of data"

  cat <<EOF | kubectl apply -f -
apiVersion: v1
kind: ConfigMap
metadata:
  name: $CONFIGMAP_NAME
  namespace: $NAMESPACE
data:
  payload: |
    $(generate_large_data)
EOF

done

echo "Finished creating $NUM_CONFIGMAPS ConfigMaps in namespace '$NAMESPACE'"

Validated both metrics are identical
Compared pod memory usage and validated that there is a spike with the old configmap collection and no spike with the new implementation

Old implementation with large spikes - Link to Data

New implementation with minimal spikes - Link to Data

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2024-12-18T22:41:51Z

Uncompressed package size comparison

Comparison with ancestor 3e0bdff730c0e24d15abd0dfc4068b1e37bbfb68

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.01MB	⚠️	1187.96MB	1187.96MB	140.00MB
datadog-agent-arm64-deb	0.01MB	⚠️	933.96MB	933.95MB	140.00MB
datadog-agent-aarch64-rpm	0.01MB	⚠️	943.20MB	943.19MB	140.00MB
datadog-agent-x86_64-rpm	0.01MB	⚠️	1197.22MB	1197.22MB	140.00MB
datadog-agent-x86_64-suse	0.01MB	⚠️	1197.22MB	1197.22MB	140.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.57MB	78.57MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.64MB	78.64MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.64MB	78.64MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.77MB	55.77MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	504.87MB	504.87MB	70.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.33MB	113.33MB	10.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.40MB	113.40MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.40MB	113.40MB	10.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.80MB	108.80MB	10.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.87MB	108.87MB	10.00MB

Decision

⚠️ Warning

agent-platform-auto-pr · 2024-12-18T22:43:47Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51657549 --os-family=ubuntu

Note: This applies to commit 1bc0ea5

agent-platform-auto-pr · 2024-12-18T22:44:07Z

[Fast Unit Tests Report]

On pipeline 51657549 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

…_state_configmap_count_collection

releasenotes/notes/optimize-ksm-configmap-collection-1e3eb7425a7af050.yaml

cit-pr-commenter · 2024-12-19T18:05:56Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a87bb5c7-cdee-42c8-95b9-f75f4b1b13f4

Baseline: 3e0bdff
Comparison: 1bc0ea5
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.97	[-2.28, +4.22]	1	Logs
➖	quality_gate_idle	memory utilization	+0.67	[+0.64, +0.70]	1	Logs bounds checks dashboard
➖	otel_to_otel_logs	ingress throughput	+0.50	[-0.15, +1.15]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.34	[+0.25, +0.43]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.07	[-0.39, +0.53]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.04	[-0.70, +0.79]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.04	[-0.87, +0.94]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.90, +0.92]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.10, +0.12]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.01	[-0.87, +0.89]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.03	[-0.67, +0.61]	1	Logs
➖	file_tree	memory utilization	-0.04	[-0.17, +0.09]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.04	[-0.11, +0.03]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.05	[-0.83, +0.73]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.41	[-1.20, +0.39]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-2.97	[-3.64, -2.30]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

sblumenthal

Change looks good, small note on releasenotes file location

releasenotes/notes/optimize-ksm-configmap-collection-1e3eb7425a7af050.yaml

…_state_configmap_count_collection

ewoodthomas · 2024-12-20T16:09:00Z

/merge

dd-devflow · 2024-12-20T16:09:12Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-20 16:09:12 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 33m.

2024-12-20 16:48:25 UTC ℹ️ MergeQueue: This merge request was merged

Optimize kube_state configmap collection

36de342

ewoodthomas added the qa/done QA done before merge and regressions are covered by tests label Dec 18, 2024

github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 18, 2024

ewoodthomas changed the title ~~Optimize kube_state configmap collection~~ [CONTINT-4416] Optimize KSM configmap collection Dec 18, 2024

ewoodthomas added 2 commits December 18, 2024 17:13

added release note

243d51d

Improved release note clarity

83d4fd7

ewoodthomas marked this pull request as ready for review December 19, 2024 17:03

ewoodthomas requested review from a team as code owners December 19, 2024 17:03

Merge branch 'main' into ewoodthomas/CONTINT-4416_optimize_kubernetes…

c95d192

…_state_configmap_count_collection

brett0000FF approved these changes Dec 19, 2024

View reviewed changes

releasenotes/notes/optimize-ksm-configmap-collection-1e3eb7425a7af050.yaml Outdated Show resolved Hide resolved

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 19, 2024

Added resource version to prevent unintentional resyncs

ab242af

sblumenthal approved these changes Dec 19, 2024

View reviewed changes

releasenotes/notes/optimize-ksm-configmap-collection-1e3eb7425a7af050.yaml Outdated Show resolved Hide resolved

ewoodthomas added 2 commits December 19, 2024 17:47

Clarified release note and moved to dca folder

6d29b55

Merge branch 'main' into ewoodthomas/CONTINT-4416_optimize_kubernetes…

1bc0ea5

…_state_configmap_count_collection

dd-devflow bot mentioned this pull request Dec 20, 2024

Update logging around configsync and fix false notification when the configuration was not updated #32243

Open

dd-mergequeue bot merged commit fdd7787 into main Dec 20, 2024
219 checks passed

dd-mergequeue bot deleted the ewoodthomas/CONTINT-4416_optimize_kubernetes_state_configmap_count_collection branch December 20, 2024 16:48

github-actions bot added this to the 7.62.0 milestone Dec 20, 2024

ewoodthomas added the team/container-integrations label Dec 20, 2024

louis-cqrl pushed a commit that referenced this pull request Dec 25, 2024

[CONTINT-4416] Optimize KSM configmap collection (#32368)

6e60d34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CONTINT-4416] Optimize KSM configmap collection #32368

[CONTINT-4416] Optimize KSM configmap collection #32368

ewoodthomas commented Dec 18, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 18, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 18, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 18, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 19, 2024 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

sblumenthal left a comment

ewoodthomas commented Dec 20, 2024

dd-devflow bot commented Dec 20, 2024 •

edited

Loading

[CONTINT-4416] Optimize KSM configmap collection #32368

[CONTINT-4416] Optimize KSM configmap collection #32368

Conversation

ewoodthomas commented Dec 18, 2024 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Dec 18, 2024 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Dec 18, 2024 • edited Loading

Test changes on VM

agent-platform-auto-pr bot commented Dec 18, 2024 • edited Loading

cit-pr-commenter bot commented Dec 19, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

sblumenthal left a comment

Choose a reason for hiding this comment

ewoodthomas commented Dec 20, 2024

dd-devflow bot commented Dec 20, 2024 • edited Loading

Devflow running: /merge

ewoodthomas commented Dec 18, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 18, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 18, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 18, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 19, 2024 •

edited

Loading

dd-devflow bot commented Dec 20, 2024 •

edited

Loading

Devflow running: `/merge`