Reapply "[ASCII-2587] Migrating TraceAgent to use IPC cert" #32355

misteriaud · 2024-12-18T17:05:44Z

Reverts #32320
The original PR was failing due to a failing e2e test (trying to connect to http and not https)

The first commit is the squash of the original PR (#31847).
The second commit is the fix for the failing e2e test.

…32320)" This reverts commit 6d0ce2d.

agent-platform-auto-pr · 2024-12-18T17:38:18Z

Uncompressed package size comparison

Comparison with ancestor 37634072805c45b57216ee880e06e380257056e7

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-arm64-deb	0.00MB	✅	933.88MB	933.87MB	140.00MB
datadog-agent-aarch64-rpm	0.00MB	✅	943.12MB	943.11MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.79MB	108.79MB	10.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.86MB	108.86MB	10.00MB
datadog-agent-amd64-deb	0.00MB	✅	1187.89MB	1187.89MB	140.00MB
datadog-agent-x86_64-rpm	0.00MB	✅	1197.15MB	1197.15MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	✅	1197.15MB	1197.15MB	140.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.57MB	78.57MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.64MB	78.64MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.64MB	78.64MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.77MB	55.77MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	504.86MB	504.86MB	70.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.32MB	113.32MB	10.00MB
datadog-iot-agent-x86_64-rpm	-0.00MB	✅	113.39MB	113.39MB	10.00MB
datadog-iot-agent-x86_64-suse	-0.00MB	✅	113.39MB	113.39MB	10.00MB

Decision

✅ Passed

agent-platform-auto-pr · 2024-12-18T17:38:35Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51608556 --os-family=ubuntu

Note: This applies to commit bda75e0

cit-pr-commenter · 2024-12-18T18:10:01Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3e2cc999-435d-444d-a7d1-e81a4e5e8ada

Baseline: 3763407
Comparison: bda75e0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.18	[-1.09, +5.46]	1	Logs
➖	otel_to_otel_logs	ingress throughput	+1.37	[+0.64, +2.09]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.16	[-0.73, +1.04]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.13	[-0.34, +0.60]	1	Logs
➖	file_tree	memory utilization	+0.05	[-0.08, +0.19]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.04	[-0.60, +0.69]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.02	[-0.88, +0.93]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.01	[-0.78, +0.80]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.00	[-0.85, +0.84]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.13, +0.11]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.72, +0.68]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.05	[-0.82, +0.72]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.54	[-0.62, -0.46]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.67	[-0.73, -0.61]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.94	[-1.61, -0.26]	1	Logs
➖	quality_gate_idle	memory utilization	-1.50	[-1.54, -1.47]	1	Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_0ms_latency_http1	lost_bytes	9/10
❌	file_to_blackhole_300ms_latency	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

misteriaud · 2024-12-18T18:36:58Z

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

dd-devflow · 2024-12-18T18:37:41Z

Devflow running: `/trigger-ci --variable RUN_ALL_BUILDS=true --varia...`

View all feedbacks in Devflow UI.

2024-12-18 18:37:41 UTC ℹ️ Gitlab pipeline started

Started pipeline #51485214

…587-migrating-trace-agent-to-use-IPC-cert

misteriaud · 2024-12-18T21:26:26Z

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

dd-devflow · 2024-12-18T21:26:42Z

Devflow running: `/trigger-ci --variable RUN_ALL_BUILDS=true --varia...`

View all feedbacks in Devflow UI.

2024-12-18 21:26:42 UTC ℹ️ Branch synced on Gitlab

Branch revert-32320-revert-31847-misteriaud/ASCII-2587-migrating-trace-agent-to-use-IPC-cert was out-of-sync on Gitlab - it has been resynced

2024-12-18 21:27:21 UTC ℹ️ Gitlab pipeline started

Started pipeline #51503491

…587-migrating-trace-agent-to-use-IPC-cert

misteriaud · 2024-12-19T21:27:36Z

/merge

dd-devflow · 2024-12-19T21:27:43Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-19 21:27:42 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 33m.

2024-12-19 22:01:54 UTC ℹ️ MergeQueue: This merge request was merged

Revert "Revert "[ASCII-2587] Migrating TraceAgent to use IPC cert" (#…

5f17011

…32320)" This reverts commit 6d0ce2d.

github-actions bot added long review PR is complex, plan time to review it team/agent-apm trace-agent labels Dec 18, 2024

fix configsync e2e test

58f0246

misteriaud added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Dec 18, 2024

misteriaud marked this pull request as ready for review December 18, 2024 20:26

misteriaud requested review from a team as code owners December 18, 2024 20:26

misteriaud requested a review from louis-cqrl December 18, 2024 20:26

jeremy-hanna approved these changes Dec 18, 2024

View reviewed changes

misteriaud removed the request for review from louis-cqrl December 18, 2024 20:34

ajgajg1134 approved these changes Dec 18, 2024

View reviewed changes

Merge branch 'main' into revert-32320-revert-31847-misteriaud/ASCII-2…

df596c3

…587-migrating-trace-agent-to-use-IPC-cert

misteriaud added 2 commits December 19, 2024 10:13

Merge branch 'main' into revert-32320-revert-31847-misteriaud/ASCII-2…

8a027f8

…587-migrating-trace-agent-to-use-IPC-cert

Merge branch 'main' into revert-32320-revert-31847-misteriaud/ASCII-2…

bda75e0

…587-migrating-trace-agent-to-use-IPC-cert

dd-mergequeue bot merged commit 88a7672 into main Dec 19, 2024
229 checks passed

dd-mergequeue bot deleted the revert-32320-revert-31847-misteriaud/ASCII-2587-migrating-trace-agent-to-use-IPC-cert branch December 19, 2024 22:01

github-actions bot added this to the 7.62.0 milestone Dec 19, 2024

louis-cqrl pushed a commit that referenced this pull request Dec 25, 2024

Reapply "[ASCII-2587] Migrating TraceAgent to use IPC cert" (#32355)

6cdd5e2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reapply "[ASCII-2587] Migrating TraceAgent to use IPC cert" #32355

Reapply "[ASCII-2587] Migrating TraceAgent to use IPC cert" #32355

misteriaud commented Dec 18, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 18, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 18, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 18, 2024 •

edited

Loading

Fine details of change detection per experiment

Explanation

misteriaud commented Dec 18, 2024

dd-devflow bot commented Dec 18, 2024

misteriaud commented Dec 18, 2024

dd-devflow bot commented Dec 18, 2024 •

edited

Loading

misteriaud commented Dec 19, 2024

dd-devflow bot commented Dec 19, 2024 •

edited

Loading

Reapply "[ASCII-2587] Migrating TraceAgent to use IPC cert" #32355

Reapply "[ASCII-2587] Migrating TraceAgent to use IPC cert" #32355

Conversation

misteriaud commented Dec 18, 2024 • edited Loading

agent-platform-auto-pr bot commented Dec 18, 2024 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Dec 18, 2024 • edited Loading

Test changes on VM

cit-pr-commenter bot commented Dec 18, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

misteriaud commented Dec 18, 2024

dd-devflow bot commented Dec 18, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

misteriaud commented Dec 18, 2024

dd-devflow bot commented Dec 18, 2024 • edited Loading

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

misteriaud commented Dec 19, 2024

dd-devflow bot commented Dec 19, 2024 • edited Loading

Devflow running: /merge

misteriaud commented Dec 18, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 18, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 18, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 18, 2024 •

edited

Loading

Devflow running: `/trigger-ci --variable RUN_ALL_BUILDS=true --varia...`

dd-devflow bot commented Dec 18, 2024 •

edited

Loading

Devflow running: `/trigger-ci --variable RUN_ALL_BUILDS=true --varia...`

dd-devflow bot commented Dec 19, 2024 •

edited

Loading

Devflow running: `/merge`