[ASCII-2613] Remove golang.org/x/text/cases from some builds #32216

pgimalac · 2024-12-16T12:10:47Z

What does this PR do?

Remove golang.org/x/text/cases from some builds.

Motivation

The dependencies are not needed just to capitalize the first letter of a string.

I'm hoping this reduces binary size a bit.
EDIT: -0.3MB, not a lot but considering the change is pretty small we might as well merge it.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2024-12-16T12:12:03Z

Go Package Import Differences

Baseline: fde3c5b
Comparison: 9bb335d

binary	os	arch	change
serverless	linux	amd64	+0, -6 -golang.org/x/text/cases -golang.org/x/text/internal -golang.org/x/text/internal/language -golang.org/x/text/internal/language/compact -golang.org/x/text/internal/tag -golang.org/x/text/language
serverless	linux	arm64	+0, -6 -golang.org/x/text/cases -golang.org/x/text/internal -golang.org/x/text/internal/language -golang.org/x/text/internal/language/compact -golang.org/x/text/internal/tag -golang.org/x/text/language
trace-agent	linux	amd64	+0, -6 -golang.org/x/text/cases -golang.org/x/text/internal -golang.org/x/text/internal/language -golang.org/x/text/internal/language/compact -golang.org/x/text/internal/tag -golang.org/x/text/language
trace-agent	linux	arm64	+0, -6 -golang.org/x/text/cases -golang.org/x/text/internal -golang.org/x/text/internal/language -golang.org/x/text/internal/language/compact -golang.org/x/text/internal/tag -golang.org/x/text/language
trace-agent	windows	amd64	+0, -6 -golang.org/x/text/cases -golang.org/x/text/internal -golang.org/x/text/internal/language -golang.org/x/text/internal/language/compact -golang.org/x/text/internal/tag -golang.org/x/text/language
trace-agent	darwin	amd64	+0, -6 -golang.org/x/text/cases -golang.org/x/text/internal -golang.org/x/text/internal/language -golang.org/x/text/internal/language/compact -golang.org/x/text/internal/tag -golang.org/x/text/language
trace-agent	darwin	arm64	+0, -6 -golang.org/x/text/cases -golang.org/x/text/internal -golang.org/x/text/internal/language -golang.org/x/text/internal/language/compact -golang.org/x/text/internal/tag -golang.org/x/text/language
heroku-trace-agent	linux	amd64	+0, -6 -golang.org/x/text/cases -golang.org/x/text/internal -golang.org/x/text/internal/language -golang.org/x/text/internal/language/compact -golang.org/x/text/internal/tag -golang.org/x/text/language

agent-platform-auto-pr · 2024-12-16T12:14:11Z

Uncompressed package size comparison

Comparison with ancestor fde3c5b85c546793f1899f942f9afa7e8583269b

Diff per package

package	diff	status	size	ancestor	threshold
datadog-iot-agent-aarch64-rpm	0.00MB	⚠️	108.83MB	108.83MB	10.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	⚠️	113.35MB	113.35MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	⚠️	113.35MB	113.35MB	10.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.28MB	113.28MB	10.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.76MB	108.76MB	10.00MB
datadog-dogstatsd-arm64-deb	-0.03MB	✅	55.71MB	55.74MB	10.00MB
datadog-dogstatsd-amd64-deb	-0.03MB	✅	78.48MB	78.52MB	10.00MB
datadog-dogstatsd-x86_64-rpm	-0.03MB	✅	78.56MB	78.59MB	10.00MB
datadog-dogstatsd-x86_64-suse	-0.03MB	✅	78.56MB	78.59MB	10.00MB
datadog-heroku-agent-amd64-deb	-0.25MB	✅	505.17MB	505.42MB	70.00MB
datadog-agent-aarch64-rpm	-0.27MB	✅	1012.89MB	1013.16MB	140.00MB
datadog-agent-arm64-deb	-0.27MB	✅	1003.68MB	1003.95MB	140.00MB
datadog-agent-x86_64-rpm	-0.28MB	✅	1277.82MB	1278.10MB	140.00MB
datadog-agent-x86_64-suse	-0.28MB	✅	1277.82MB	1278.10MB	140.00MB
datadog-agent-amd64-deb	-0.28MB	✅	1268.58MB	1268.87MB	140.00MB

Decision

⚠️ Warning

agent-platform-auto-pr · 2024-12-16T12:14:48Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51419473 --os-family=ubuntu

Note: This applies to commit 9bb335d

dustmop

LGTM

StephenWakely

It will be great to remove some dependencies! There's a couple of edge cases I think we need to handle..

StephenWakely · 2024-12-18T09:25:18Z

comp/forwarder/defaultforwarder/internal/retry/telemetry.go

 	parts := strings.Split(s, "_")
 	var camelCase string
 	for _, p := range parts {
-		camelCase += caser.String(p)
+		camelCase += strings.ToUpper(string(p[0]))
+		camelCase += string(p[1:])


This will panic if you:

call on a string with two underscores. toCamelCase("thing__thang")

call on a string with a trailing underscore, toCamelCase("thing_thang_")

call on a string that starts with an underscore, toCamelCase("_thing_thang")

Can we handle these case?

The strings are hard coded above in the file, and they all have the expected format, do you still think I should handle those cases ?

OK to be fair it’s just about correctly handling the empty string so it’s trivial enough

I just handled empty strings, the current code should be equivalent to the previous one, let me know

Ah, I didn't fully check the context, but at minimum a comment warning about the edge cases to prevent it being reused somewhere else would be useful.

comp/core/status/render_helpers.go

StephenWakely

Perfect!

cit-pr-commenter · 2024-12-18T11:01:39Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f0434d37-9e17-4644-bb93-ed4b271b2151

Baseline: fde3c5b
Comparison: 9bb335d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.48	[-0.25, +1.20]	1	Logs
➖	quality_gate_idle	memory utilization	+0.40	[+0.36, +0.44]	1	Logs bounds checks dashboard
➖	otel_to_otel_logs	ingress throughput	+0.34	[-0.33, +1.00]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.24	[-0.23, +0.70]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.03	[-0.61, +0.66]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.02	[-0.80, +0.85]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.10, +0.10]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.80, +0.77]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.02	[-0.82, +0.79]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.85, +0.81]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.06	[-0.84, +0.71]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.07	[-0.84, +0.70]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.15	[-3.10, +2.81]	1	Logs
➖	file_tree	memory utilization	-0.23	[-0.34, -0.11]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.35	[-0.40, -0.29]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.50	[-0.62, -0.38]	1	Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_0ms_latency_http2	lost_bytes	8/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

pgimalac · 2024-12-19T09:07:20Z

/merge

dd-devflow · 2024-12-19T09:07:28Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-19 09:07:28 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.

2024-12-19 09:47:45 UTC ℹ️ MergeQueue: This merge request was merged

chore: remove golang.org/x/text/cases

6374c7b

pgimalac added changelog/no-changelog team/agent-shared-components qa/done QA done before merge and regressions are covered by tests labels Dec 16, 2024

github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 16, 2024

pgimalac changed the title ~~Remove golang.org/x/text/cases from some builds~~ [ASCII-2613] Remove golang.org/x/text/cases from some builds Dec 16, 2024

pgimalac marked this pull request as ready for review December 17, 2024 10:18

pgimalac requested review from a team as code owners December 17, 2024 10:18

pgimalac requested a review from dustmop December 17, 2024 10:18

dustmop approved these changes Dec 17, 2024

View reviewed changes

StephenWakely requested changes Dec 18, 2024

View reviewed changes

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 18, 2024

fix: correctly handle empty strings

9bb335d

StephenWakely approved these changes Dec 18, 2024

View reviewed changes

dd-mergequeue bot merged commit 463c776 into main Dec 19, 2024
224 checks passed

dd-mergequeue bot deleted the pgimalac/remove-golang-x-text-cases branch December 19, 2024 09:47

github-actions bot added this to the 7.62.0 milestone Dec 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ASCII-2613] Remove golang.org/x/text/cases from some builds #32216

[ASCII-2613] Remove golang.org/x/text/cases from some builds #32216

pgimalac commented Dec 16, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 16, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 16, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 16, 2024 •

edited

Loading

dustmop left a comment

StephenWakely left a comment

StephenWakely Dec 18, 2024

pgimalac Dec 18, 2024

pgimalac Dec 18, 2024

pgimalac Dec 18, 2024

StephenWakely Dec 18, 2024

StephenWakely left a comment

cit-pr-commenter bot commented Dec 18, 2024

Fine details of change detection per experiment

Explanation

pgimalac commented Dec 19, 2024

dd-devflow bot commented Dec 19, 2024 •

edited

Loading

[ASCII-2613] Remove golang.org/x/text/cases from some builds #32216

[ASCII-2613] Remove golang.org/x/text/cases from some builds #32216

Conversation

pgimalac commented Dec 16, 2024 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter bot commented Dec 16, 2024 • edited Loading

Go Package Import Differences

agent-platform-auto-pr bot commented Dec 16, 2024 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Dec 16, 2024 • edited Loading

Test changes on VM

dustmop left a comment

Choose a reason for hiding this comment

StephenWakely left a comment

Choose a reason for hiding this comment

StephenWakely Dec 18, 2024

Choose a reason for hiding this comment

pgimalac Dec 18, 2024

Choose a reason for hiding this comment

pgimalac Dec 18, 2024

Choose a reason for hiding this comment

pgimalac Dec 18, 2024

Choose a reason for hiding this comment

StephenWakely Dec 18, 2024

Choose a reason for hiding this comment

StephenWakely left a comment

Choose a reason for hiding this comment

cit-pr-commenter bot commented Dec 18, 2024

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

pgimalac commented Dec 19, 2024

dd-devflow bot commented Dec 19, 2024 • edited Loading

Devflow running: /merge

pgimalac commented Dec 16, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 16, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 16, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 16, 2024 •

edited

Loading

dd-devflow bot commented Dec 19, 2024 •

edited

Loading

Devflow running: `/merge`