Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge attributes and support multiple configs for failover #31761

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Merge attributes and support multiple configs for failover #31761

merged 6 commits into from
Dec 20, 2024

Conversation

Hitsuji-M
Copy link
Contributor

What does this PR do?

Read all the AGENT_FAILOVER configs and merge the boolean attributes by using an OR condition.

Motivation

We want to be able to send multiple configs with the policies systems in Fleet Automation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@Hitsuji-M Hitsuji-M self-assigned this Dec 4, 2024
@github-actions github-actions bot added team/remote-config medium review PR review might take time labels Dec 4, 2024
@Hitsuji-M Hitsuji-M added team/fleet-automation qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Dec 4, 2024
@cit-pr-commenter cit-pr-commenter

This comment was marked as resolved.

Sign in to view
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 5, 2024 •
edited
Loading

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51532437 --os-family=ubuntu

Note: This applies to commit f756f65

@Hitsuji-M Hitsuji-M marked this pull request as ready for review December 9, 2024 08:56
@Hitsuji-M Hitsuji-M requested a review from a team as a code owner December 9, 2024 08:56
timothyalexandersoftware
timothyalexandersoftware reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@timothyalexandersoftware timothyalexandersoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple small log message changes

@agent-platform-auto-pr

This comment was marked as resolved.

Sign in to view
@Hitsuji-M
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 20, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-20 09:48:48 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 33m.

2024-12-20 10:24:07 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit a75b1ca into main Dec 20, 2024
221 checks passed
@dd-mergequeue dd-mergequeue bot deleted the erwann.masson/ddr-merge-attributes branch December 20, 2024 10:24
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 20, 2024
louis-cqrl pushed a commit that referenced this pull request Dec 25, 2024
@Hitsuji-M @louis-cqrl
Merge attributes and support multiple configs for failover (#31761)
6b45003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothyalexandersoftware timothyalexandersoftware timothyalexandersoftware approved these changes

@michael-richey michael-richey michael-richey approved these changes

@heyronhay heyronhay heyronhay approved these changes

Assignees

@Hitsuji-M Hitsuji-M

Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/fleet-automation team/remote-config
Projects
None yet
Milestone
7.62.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Hitsuji-M @heyronhay @michael-richey @timothyalexandersoftware