Closed
Description
Cookbook version: 2.13.0
When including recipe datadog::dd-handler warning is issued during chef run:
[2017-12-26T10:46:07+00:00] WARN: chef_handler::default recipe has been deprecated. Use the chef_handler resource instead to define handlers from your own wrapper cookbook.
Recipe: datadog::dd-handler
* chef_gem[chef-handler-datadog] action install (up to date)
* chef_handler[Chef::Handler::Datadog] action enable (up to date)
Metadata
Metadata
Assignees
Labels
No labels
Activity
olivielpeau commentedon Feb 13, 2018
Hi @ayarmoluk17, thanks for reporting this!
Looks like the
chef_handlerresource was added in v1.4.0of the chef_handler cookbook (see https://github.com/chef-cookbooks/chef_handler/blob/master/CHANGELOG.md#v140-2016-05-13).I think it's a good idea to increase our version constraint on that cookbook to
~>1.4.0, #396 would be a good base to start from. I'll work on that if I have some time (or if the warning becomes a breaking change onchef_handler's side), but feel free to contribute if you have the chance!iennae commentedon Apr 2, 2018
@olivielpeau I wouldn't recommend pinning to 1.4.0 especially with the 2.1.1 version including the fix for Chef 13 compatibility.
olivielpeau commentedon Apr 4, 2018
@iennae you're right, thanks for mentioning this, I should've written
>=1.4.0, we definitely want to allow versions ofchef_handlerthat are compatible with Chef 13.(as an aside, the metadata currently allows any
chef_handlerversion>= 1.1https://github.com/DataDog/chef-datadog/blob/v2.15.0/metadata.rb#L26)remeh commentedon Mar 22, 2019
Thanks to both of you for your contribution! Having removed the
include_recipein #597 should remove the warning mentioned here.We're aware of the deprecation of chef_handler but unfortunately, as mentioned in the PR we still need this dep for Chef 12 / 13 for now.
The deprecation warning mentioned here being removed by the PR, I'm closing this issue 👍