Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Use registerCleanupTask for mock cleanups #3069

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Oct 11, 2024

Motivation

  • Use registerCleanupTask for mockXhr cleanup
  • Use registerCleanupTask for mockSyntheticsWorkerValues cleanup

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner October 11, 2024 14:14
@amortemousque amortemousque changed the title /use register cleanup task next ♻️ Use registerCleanupTask for mock cleanups Oct 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (49e388a) to head (5266ea1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3069      +/-   ##
==========================================
+ Coverage   93.20%   93.50%   +0.29%     
==========================================
  Files         276      276              
  Lines        7627     7624       -3     
  Branches     1711     1710       -1     
==========================================
+ Hits         7109     7129      +20     
+ Misses        518      495      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants