Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [RUM 6075] Save anonymous id in session cookie #2985

Open
wants to merge 18 commits into
base: v6
Choose a base branch
from
Open

✨ [RUM 6075] Save anonymous id in session cookie #2985

wants to merge 18 commits into from

Conversation

cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Sep 11, 2024 •
edited
Loading

Motivation

Test saving anonymous id in session cookie on org2.

Changes

Add anonymous id to session cookie behind a feature flag.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@cy-moi cy-moi changed the title [RUM 6075] device in session cookie [RUM 6075] Save device id in session cookie Sep 11, 2024
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Sep 11, 2024 •
edited
Loading

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 151.27 KiB 152.54 KiB 1.27 KiB +0.84% ✅
Logs 50.84 KiB 51.93 KiB 1.09 KiB +2.14% ✅
Rum Slim 101.23 KiB 102.50 KiB 1.27 KiB +1.25% ✅
Worker 25.16 KiB 25.16 KiB 0 B 0.00% ✅
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.001 0.000
addaction 0.035 0.030 -0.005
addtiming 0.001 0.001 -0.000
adderror 0.035 0.030 -0.005
startstopsessionreplayrecording 0.745 0.693 -0.051
startview 1.072 0.949 -0.123
logmessage 0.018 0.018 -0.000
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 8.57 KiB 10.17 KiB 1.60 KiB
addaction 42.17 KiB 40.18 KiB -2039 B
addtiming 8.00 KiB 6.26 KiB -1787 B
adderror 44.56 KiB 45.30 KiB 751 B
startstopsessionreplayrecording 4.67 KiB 4.56 KiB -119 B
startview 439.64 KiB 439.32 KiB -322 B
logmessage 39.92 KiB 41.79 KiB 1.87 KiB

🔗 RealWorld

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (c364fb7) to head (75bda11).

Additional details and impacted files 
@@            Coverage Diff             @@
##               v6    #2985      +/-   ##
==========================================
+ Coverage   93.54%   93.58%   +0.04%     
==========================================
  Files         275      276       +1     
  Lines        7404     7456      +52     
  Branches     1677     1698      +21     
==========================================
+ Hits         6926     6978      +52     
  Misses        478      478

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cy-moi cy-moi force-pushed the congyao/RUM-6075-device-in-session-cookie branch from 48ecdd4 to ebbd968 Compare September 16, 2024 16:05
@cy-moi cy-moi force-pushed the congyao/RUM-6075-device-in-session-cookie branch from 1ca13a8 to c05301e Compare September 17, 2024 12:49
@cy-moi cy-moi changed the base branch from main to v6 October 11, 2024 09:45
@cy-moi cy-moi changed the title [RUM 6075] Save device id in session cookie ✨ [RUM 6075] Save device id in session cookie Oct 11, 2024
@cy-moi cy-moi force-pushed the congyao/RUM-6075-device-in-session-cookie branch from 6c2171e to a620dfb Compare October 11, 2024 09:57
@cy-moi cy-moi changed the title ✨ [RUM 6075] Save device id in session cookie ✨ [RUM 6075] Save anonymous id in session cookie Oct 11, 2024
@cy-moi cy-moi marked this pull request as ready for review October 11, 2024 11:47
@cy-moi cy-moi requested a review from a team as a code owner October 11, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cy-moi @codecov-commenter