Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add the possibility to prevent the zypper repository installation #452

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Feat: add the possibility to prevent the zypper repository installation #452

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e566f9
Feat: add the possibility to prevent the zypper repository installation
jb-mayer Aug 5, 2022
631ab36
Chore: change the variable name
jb-mayer Aug 17, 2022
be28ac5
Chore: change the variable name
jb-mayer Aug 17, 2022
8539076
Merge branch 'main' into main
jb-mayer Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ datadog_ignore_old_centos_python3_error: false
# Use the datadog_zypper_repo variable to override the repository used.
datadog_zypper_repo: ""

# Define if the official zypper Datadog repository services should be installed
datadog_zypper_repo_enabled: yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename this to datadog_manage_zypper_repo? The enabled keyword is a repofile keyword and it might the variable name confusing. Additionally, we already have a variable called datadog_manage_config, so using datadog_manage_zypper_repo would be consistent with that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, even better might be datadog_manage_zypper_repofile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I changed the variable name according to your suggestion.
Thanks.


datadog_zypper_repo_gpgcheck: ""
datadog_zypper_gpgcheck: yes
datadog_zypper_gpgkey: "https://s3.amazonaws.com/public-signing-keys/DATADOG_RPM_KEY.public"
Expand Down
1 change: 1 addition & 0 deletions tasks/pkg-suse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@
group: "root"
mode: 0644
register: datadog_zypper_repo
when: datadog_zypper_repo_enabled

# refresh zypper repos only if the template changed
- name: refresh Datadog zypper_repos # noqa 503
Expand Down