Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes Deployment Optimization and Improvements #114

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Kubernetes Deployment Optimization and Improvements #114

merged 1 commit into from
Jan 25, 2019

Conversation

bfcrampton
Copy link

No description provided.

melissachang
melissachang reviewed Dec 13, 2018
View reviewed changes
bigquery/deploy/README.md Outdated Show resolved Hide resolved
bigquery/deploy/README.md Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/es-master-stateful.yaml Outdated Show resolved Hide resolved
melissachang
melissachang reviewed Dec 18, 2018
View reviewed changes
bigquery/deploy/README.md Outdated Show resolved Hide resolved
bigquery/deploy/README.md Outdated Show resolved Hide resolved
bigquery/deploy/README.md Outdated Show resolved Hide resolved
@bfcrampton bfcrampton force-pushed the bc/query-performance branch 4 times, most recently from d069e6d to 793fdce Compare December 28, 2018 22:20
@bfcrampton bfcrampton force-pushed the bc/query-performance branch 2 times, most recently from 827a036 to ac3990f Compare January 14, 2019 22:42
melissachang
melissachang reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@melissachang melissachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit with some changes to README. I like how you broke it up into sections. But I think it went too far; I did some consolidation. If you have comments on my commit, please comment in github and I'll respond. Or ping me offline

kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/es-data-stateful.yaml Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/es-data-stateful.yaml Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/es-master-stateful.yaml Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy.sh Outdated Show resolved Hide resolved
@bfcrampton bfcrampton force-pushed the bc/query-performance branch 3 times, most recently from dd628c5 to ddd5f88 Compare January 18, 2019 00:00
melissachang
melissachang reviewed Jan 18, 2019
View reviewed changes
Copy link
Contributor

@melissachang melissachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

kubernetes-elasticsearch-cluster/es-data-stateful.yaml Outdated Show resolved Hide resolved
bigquery/deploy/bq-indexer.yaml.templ Outdated Show resolved Hide resolved
dataset_config/template/deploy.json Outdated Show resolved Hide resolved
bigquery/deploy/deploy-indexer.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/es-data-stateful.yaml Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/es-master-stateful.yaml Outdated Show resolved Hide resolved
melissachang
melissachang reviewed Jan 18, 2019
View reviewed changes
Copy link
Contributor

@melissachang melissachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update ES_CLIENT parts of the READMEs

@melissachang melissachang changed the title Kubernetes Deployment: Separate client, data, and master nodes into separate pools Kubernetes Deployment: Separate data and master ES nodes into separate pools Jan 18, 2019
melissachang
melissachang reviewed Jan 18, 2019
View reviewed changes
kubernetes-elasticsearch-cluster/deploy.sh Outdated Show resolved Hide resolved
bigquery/deploy/README.md Outdated Show resolved Hide resolved
@bfcrampton bfcrampton force-pushed the bc/query-performance branch from f79252c to 997d6f4 Compare January 18, 2019 17:05
melissachang
melissachang reviewed Jan 22, 2019
View reviewed changes
bigquery/deploy/README.md Outdated Show resolved Hide resolved
bigquery/deploy/README.md Outdated Show resolved Hide resolved
bigquery/deploy/README.md Show resolved Hide resolved
@bfcrampton bfcrampton force-pushed the bc/query-performance branch from 997d6f4 to 81cfd73 Compare January 22, 2019 23:22
melissachang
melissachang reviewed Jan 22, 2019
View reviewed changes
kubernetes-elasticsearch-cluster/deploy.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy.sh Outdated Show resolved Hide resolved
melissachang
melissachang reviewed Jan 23, 2019
View reviewed changes
bigquery/deploy/README.md Outdated Show resolved Hide resolved
bigquery/deploy/deploy-indexer.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/es-data-stateful.yaml Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy-es.sh Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy-es.sh Show resolved Hide resolved
@bfcrampton bfcrampton changed the title Kubernetes Deployment: Separate data and master ES nodes into separate pools Kubernetes Deployment Optimization: Separate data and master ES nodes into separate pools Jan 23, 2019
melissachang
melissachang reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@melissachang melissachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
bigquery/deploy/README.md Show resolved Hide resolved
bigquery/deploy/README.md Outdated Show resolved Hide resolved
bigquery/deploy/README.md Outdated Show resolved Hide resolved
bigquery/deploy/README.md Outdated Show resolved Hide resolved
@bfcrampton bfcrampton changed the title Kubernetes Deployment Optimization: Separate data and master ES nodes into separate pools Kubernetes Deployment Optimization and Improvements Jan 24, 2019
@bfcrampton bfcrampton force-pushed the bc/query-performance branch from b99d122 to 7ff2f38 Compare January 24, 2019 16:03
melissachang
melissachang reviewed Jan 24, 2019
View reviewed changes
bigquery/deploy/README.md Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
bigquery/deploy/README.md Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy-es.sh Show resolved Hide resolved
melissachang
melissachang reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@melissachang melissachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment before I leave for appt

dataset_config/template/deploy.json Outdated Show resolved Hide resolved
melissachang
melissachang reviewed Jan 24, 2019
View reviewed changes
dataset_config/template/deploy.json Show resolved Hide resolved
kubernetes-elasticsearch-cluster/create-cluster.sh Outdated Show resolved Hide resolved
bigquery/README.md Outdated Show resolved Hide resolved
bigquery/README.md Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy-es.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy-es.sh Show resolved Hide resolved
kubernetes-elasticsearch-cluster/es-data-stateful.yaml Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy-es.sh Outdated Show resolved Hide resolved
kubernetes-elasticsearch-cluster/deploy-es.sh Outdated Show resolved Hide resolved
melissachang
melissachang approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@melissachang melissachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

dataset_config/template/deploy.json Show resolved Hide resolved
Separate client, data, and master nodes into separate node pools
86bdb81 
Kubernetes Deployment Optimization and Improvements
@bfcrampton bfcrampton force-pushed the bc/query-performance branch from 190fbb8 to 86bdb81 Compare January 25, 2019 00:58
@bfcrampton bfcrampton merged commit 50731f9 into master Jan 25, 2019
This was referenced Jan 28, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissachang melissachang melissachang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfcrampton @melissachang