Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write access needed? #11

Open
echadwick-artist opened this issue May 12, 2023 · 3 comments
Open

Write access needed? #11

echadwick-artist opened this issue May 12, 2023 · 3 comments

Comments

@echadwick-artist
Copy link
Collaborator

I'm trying to commit a branch for the AnisotropyBarnLamp asset, but GitHub Desktop is telling me I don't have write access. Should I open a fork instead?

image
@DRx3D
Copy link
Owner

DRx3D commented May 12, 2023

I've invited you as a collaborator. That should give you write access. See the file util/CreateJson.html (runs locally) to assist in the creation of the JSON metadata file.

@echadwick-artist
Copy link
Collaborator Author

OK that seems to work.

However there seems to be a problem with the build checks.
Run ./gltf_validator -r -a ./2.0/ /home/runner/work/glTF-Sample-Assets/glTF-Sample-Assets/2.0 is neither a file nor a directory. Error: Process completed with exit code 1.

@emackey emackey mentioned this issue May 16, 2023
Merged
@DRx3D
Copy link
Owner

DRx3D commented May 17, 2023

Things are getting updated in pieces. In this case 2.0 is not a used folder. That change should be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DRx3D @echadwick-artist