fix(core/utils/puppeteer): proxy-chain error #11470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPS/SOCKS proxy is not supported by proxy-chain and will cause an error unconditionally. If an HTTPS/SOCKS proxy does not need authentication, explicitly bypassing proxy-chain is a must. If it does need, making a warning and continuing without proxy seems to be the best choice. Signed-off-by: Rongrong <i@rong.moe>
github-actions
bot
added
core enhancement
Auto: Route Test Skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
该 PR 相关 Issue / Involved issue
Close #
完整路由地址 / Example for the proposed route(s)
新 RSS 检查列表 / New RSS Script Checklist
Puppeteer说明 / Note
HTTPS/SOCKS proxy is not supported by proxy-chain and will cause an error unconditionally. If an HTTPS/SOCKS proxy does not need authentication, explicitly bypassing proxy-chain is a must. If it does need, making a warning and continuing without proxy seems to be the best choice.