Add custom serializers to improve app logging #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've completed a [number of changes to our logging](https://github.com/DEFRA/water-abstraction-team/issues?q=is%3Aissue%20state%3Aclosed%20log) in the time we have been on the project. Generally, we 'go to the logs' when an issue has been reported in `production`, and we need to figure out what has happened. Therefore, we constantly balance, ensuring we have all the necessary information while excluding noise. We recently [made a change to water-abstraction-system](DEFRA/water-abstraction-system#1655) to reduce the noise in our logs via custom serializers (check it out for more details). This change makes the same change to the logging in this app.
Cruikshanks
added
the
housekeeping
Cruikshanks
requested review from
robertparkinson,
Jozzey,
StuAA78,
jonathangoulding,
Beckyrose200 and
rvsiyad
robertparkinson
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've completed a number of changes to our logging in the time we have been on the project.
Generally, we 'go to the logs' when an issue has been reported in
production, and we need to figure out what has happened.Therefore, we constantly balance, ensuring we have all the necessary information while excluding noise.
We recently made a change to water-abstraction-system to reduce the noise in our logs via custom serializers (check it out for more details).
This change makes the same change to the logging in this app.