Return Logs setup - Period used #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4853 As part of the work to migrate the return logs setup journey, this PR is focused on adding the 'What period was used for this volume?' page. NOTE: This work is only for a due return. The pages will be updated in a separate PR to handle the editing of existing return logs.
|
Please ignore SonarClouds complaint about code duplication. Its because the Submit Service looks the same to every other Submit Service and it doesn't like it :) |
Beckyrose200
requested review from
Cruikshanks,
Jozzey and
rvsiyad
and removed request for
Cruikshanks and
Jozzey
Cruikshanks
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4853
As part of the work to migrate the return logs setup journey, this PR is focused on adding the 'What period was used for this volume?' page.
NOTE: This work is only for a due return. The pages will be updated in a separate PR to handle the editing of existing return logs.