Replace == in the views with ===
#1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been spotted in a few views that we have been using `==` rather than `===`. Generally we use the strict comparison `===` to compare content & type unless it is absolutely necessary to perform a loose equality comparison. It looks like it is not necessary to use `==` in the views. So where applicable they will be updated to `===`.
Jozzey
added
the
housekeeping
Jozzey
requested review from
Cruikshanks,
robertparkinson,
StuAA78,
jonathangoulding,
Beckyrose200 and
rvsiyad
Cruikshanks
reviewed
Jan 20, 2025
Running the acceptance tests highlighted an issue with the view `app/views/bill-runs/review/review-licence.njk`. It was breaking when I updated line 237 to this `{% if matchedReturns.length === 0 and unmatchedReturns.length === 0 %}`.
After some investigation I found that `matchedReturns` & `unmatchedReturns` are arrays, not numbers. The `==` seemed to work when assessing if the array was empty. Just goes to show how loose the `==` matching is.
I've therefore updated it to what I expect it should have been in the first place unmatchedReturns.length === 0 and it now works fine.
|
The acceptance tests picked up an issue with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been spotted in a few views that we have been using
==rather than===.Generally, we use the strict comparison
===to compare content & type unless it is necessary to perform a loose equality comparison.It looks like it is not necessary to use
==in the views. So where applicable they will be updated to===.