Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing output directory #660

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

martinkilbinger
Copy link
Contributor

@martinkilbinger martinkilbinger commented Oct 18, 2023

Summary

Main updates

The proposed changes in this PR allow the code to run when the output directory already exists. For this, the config entry RUN_DATETIME needs to be set to False.

Module runners can then check whether the output file to create already exists and skip computation.
As first cases this is done for mccd and ngmix.

In addition, regular expressions are allowed for the tile number IDs. This allows for a run of targeted input/output files instead of using all inputs.

This can be useful when a run is interrupted, in which case a re-run of the same module(s) will only be carried out for the still missing output files.
Some issues should be solved before merging, e.g. the log files will be overwritten.

Other changes:

  • Some minor bug fixes are implemented.
  • The job script allows to set the number of SMP cores as command line argument.

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@martinkilbinger martinkilbinger added the enhancement New feature or request label Oct 18, 2023
@martinkilbinger martinkilbinger self-assigned this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

1 participant