Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL + K does not work on Windows (CopilotTextarea and potentially others) #400

Open
arielweinberger opened this issue Jun 24, 2024 · 0 comments · May be fixed by #874
Open

CTRL + K does not work on Windows (CopilotTextarea and potentially others) #400

arielweinberger opened this issue Jun 24, 2024 · 0 comments · May be fixed by #874
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@arielweinberger
Copy link
Collaborator

Bug Report

Describe the bug
In <CopilotTextarea>, cmd + k works on a Mac to bring up the popover. However, on Windows, ctrl + k does not.
This could potentially be the case in other places where we use keyboard shortcuts.

To Reproduce
Steps to reproduce the behavior (the easier it is to replicate, the sooner it will get fixed):

  1. On a Windows machine, go to https://crm-demo-delta.vercel.app/
  2. Focus on the textarea field
  3. Type ctrl + k to open up the CopilotKit popover

Expected: The popover opens as it does on a Mac when using cmd + k.
Actual: Nothing happens

Potential Solution

We might want to look into dedicated shortcut handling libraries for JS/React that handle cross-platform key mapping differences. We need to make sure it's fixed in other places that keyboard shortcuts.

@arielweinberger arielweinberger added the bug Something isn't working label Jun 24, 2024
@arielweinberger arielweinberger changed the title CTRL + K does not work on Windows (CopilotTextarae and potentially others) CTRL + K does not work on Windows (CopilotTextarea and potentially others) Jun 24, 2024
@arielweinberger arielweinberger added the good first issue Good for newcomers label Jul 17, 2024
@kilbha kilbha linked a pull request Nov 2, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
1 participant