Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rimble-icons to rimble-ui repo #431

Open
12 tasks done
MikeLockz opened this issue Dec 9, 2019 · 1 comment
Open
12 tasks done

Add rimble-icons to rimble-ui repo #431

MikeLockz opened this issue Dec 9, 2019 · 1 comment
Assignees
@MikeLockz
Labels
enhancement New feature or request
Milestone
Version 1.0

Comments

@MikeLockz
Copy link
Contributor

MikeLockz commented Dec 9, 2019 •
edited
Loading

  • Icons should accept a size prop
  • Icons should accept a color prop
  • Should have a default color for crypto icons (whatever default color is)
  • Should have a 'inherit' as color prop value for all non-crypto icons
  • Should be used with rimble-ui Icon component api
  • Should be importable as named imports
  • Should be importable as wildcard import { * }
  • Should honor space properties from styled-system as rimble-ui Icon
  • Should honor space properties from styled-system when imported directly via named import (when imported directly)
  • Should be documented on Storefront (https://github.com/ConsenSys/rimble-storefront/pull/217)
  • Rename all references of "crypto" to "tokens"
  • Should honor theme color value from styled-system
@MikeLockz MikeLockz self-assigned this Dec 9, 2019
@MikeLockz MikeLockz added this to the Version 1.0 milestone Dec 9, 2019
@MikeLockz MikeLockz added the enhancement New feature or request label Dec 9, 2019
@MikeLockz
Copy link
Contributor Author

Fix rimble-ui install and build errors:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeLockz MikeLockz

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
1 participant
@MikeLockz