Sprockets 3 support #246
Sprockets 3 support #246
Conversation
Based on #236, I’m bumping the version to 3.0.0
#trail no longer exists, and the functionality in Sprockets 3 now exists in the Sprockets::Environment class (and its cached sibling).
#trail is a protected method.
This should allow Sprockets 2 to be installed for Rails 3
|
We would very much love this to get merged. I believe being stuck on an old version of sprockets exposes us to this: sstephenson/sprockets#441 |
|
+1 for merging this PR. I am using this branch without any problems. |
This commit changes the root of the file cache to match the default in sprockets-rails and write to the app-level tmp folder. This also has the added benefit of segregating asset caches by environment.
|
This should fix #232, #236, and #244 - @craigmcnamara any comments? |
|
@robkilby That's really cool but i get when trying to make a sprite! |
|
Thanks for the feedback @mib32. I'll look into the issue over the weekend. |
|
@robkilby thanks, i'm also working on this |
|
@robkilby Forget that, it is a bug in compass-core, which is already deprecated, so it's impossible to fix. I'll use sprite_factory for my sprites! |
Reflects the cache directory fix.
|
I also am using this branch without any problems. |
|
Any update on getting this merged? |
|
I've been using Thanks! |
|
Same here, +1 for this PR! |
|
Now that this is merged, can we get a release to RubyGems? |
|
+1 for a new release |
|
👍 New release, please. |
|
Could it be that Sprockets 3 support is still buggy? See #256 |
|
Could we please get a new release? |
This PR builds upon the work done by @urkle in his fork. I’ve also provided fixes for the lack of Hike in later builds of Sprockets.
All tests are passing locally on both builds of Sprockets 2 and Sprockets 3.