Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: search paste support #881

Merged
merged 7 commits into from
Nov 10, 2022
Merged

feature: search paste support #881

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e7135d6
feature: add pasting to search
ClementTsang Nov 9, 2022
1acc3f8
update docs
ClementTsang Nov 9, 2022
e5ba852
clippy
ClementTsang Nov 9, 2022
5271210
comment
ClementTsang Nov 9, 2022
7675ffa
Update process.md
ClementTsang Nov 9, 2022
81636c9
remove keyboard event throttle
ClementTsang Nov 10, 2022
17a6c12
fix issues with cjk/flag characters
ClementTsang Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment
  • Loading branch information
@ClementTsang
ClementTsang committed Nov 9, 2022
commit 5271210542d837260d51f347a17e912fa465bbc7
2 changes: 1 addition & 1 deletion docs/content/usage/widgets/process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ Lastly, we can refine our search even further based on the other columns, like P
<img src="../../../assets/screenshots/process/search/cpu.webp" alt="A picture of searching for a process with a search condition that uses the CPU keyword."/>
</figure>

You can also paste search queries (e.g. ++shift+insert++, ++ctrl+shift+v++).
You can also paste search queries (e.g. ++shift+insert++, ++ctrl+shift+v++), though this may not work in Windows.

#### Keywords

Expand Down
3 changes: 2 additions & 1 deletion src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2718,7 +2718,8 @@ impl App {

/// A quick and dirty way to handle paste events.
pub fn handle_paste(&mut self, paste: String) {
// Partially copy-pasted from the single-char variant; should probably optimize this process in the future.
// Partially copy-pasted from the single-char variant; should probably clean up this process in the future.
// In particular, encapsulate this entire logic and add some tests to make it less potentially error-prone.
let is_in_search_widget = self.is_in_search_widget();
if let Some(proc_widget_state) = self
.proc_state
Expand Down