more comments

ClementTsang · ClementTsang · Apr 10, 2023 · Mar 9, 2023 · Mar 11, 2023 · Mar 14, 2023
commit 26282540ce94fa3e4433bd49b0b70da655840dfa
diff --git a/src/app/data_harvester/disks/system/linux/io_counters.rs b/src/app/data_harvester/disks/system/linux/io_counters.rs
@@ -96,6 +96,7 @@ pub fn io_stats() -> anyhow::Result<Vec<anyhow::Result<IoCounters>>> {
     let mut reader = BufReader::new(File::open(PROC_DISKSTATS)?);
     let mut line = String::new();
 
+    // This saves us from doing a string allocation on each iteration compared to `lines()`.
     while let Ok(bytes) = reader.read_line(&mut line) {
         if bytes > 0 {
             results.push(IoCounters::from_str(&line));

diff --git a/src/app/data_harvester/disks/system/linux/partition.rs b/src/app/data_harvester/disks/system/linux/partition.rs
@@ -153,6 +153,7 @@ pub(crate) fn partitions() -> anyhow::Result<Vec<Partition>> {
     let mut reader = BufReader::new(File::open(PROC_MOUNTS)?);
     let mut line = String::new();
 
+    // This saves us from doing a string allocation on each iteration compared to `lines()`.
     while let Ok(bytes) = reader.read_line(&mut line) {
         if bytes > 0 {
             if let Ok(partition) = Partition::from_str(&line) {
@@ -177,6 +178,7 @@ pub(crate) fn physical_partitions() -> anyhow::Result<Vec<Partition>> {
     let mut reader = BufReader::new(File::open(PROC_MOUNTS)?);
     let mut line = String::new();
 
+    // This saves us from doing a string allocation on each iteration compared to `lines()`.
     while let Ok(bytes) = reader.read_line(&mut line) {
         if bytes > 0 {
             if let Ok(partition) = Partition::from_str(&line) {