Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(images): reduce images size #126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(images): reduce images size #126

wants to merge 2 commits into from

Conversation

AmnezziaCS
Copy link
Member

@AmnezziaCS AmnezziaCS commented Dec 6, 2022 •
edited by nfroidure
Loading

fix #111

Still in progress, no way to figure out how to use this and the expected result is unclear.

To test, run npm run build && npm run export got to the ChtiJS24 page and see the image.

@AmnezziaCS AmnezziaCS self-assigned this Dec 6, 2022
Hugo59530
Hugo59530 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@Hugo59530 Hugo59530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nfroidure
Copy link
Member

@amnezziaa finally ended not using this plugin for my own blog: https://github.com/nfroidure/politics/pull/1/files

I found out his too: https://github.com/cyrilwanner/next-optimized-images
A third version is coming, but not sure it is compatible nor if it works with static exports, see: cyrilwanner/next-optimized-images#287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hugo59530 Hugo59530 Hugo59530 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@AmnezziaCS AmnezziaCS

Labels
do not merge enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize images
3 participants
@AmnezziaCS @nfroidure @Hugo59530