fix: str_to_raw_id() may return empty id (#23)

Chaoses-Ib · Feb 12, 2024 · 4a23832 · 4a23832
1 parent b6ef34c
commit 4a23832
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/comfy_script/astutil.py b/src/comfy_script/astutil.py
@@ -35,7 +35,9 @@ def str_to_raw_id(s: str) -> str:
             s = f'_{s}'
     s = re.sub(r'__+', '_', s)
     s = s.rstrip('_')
-
+    if s == '':
+        s = '_'
+
     if keyword.iskeyword(s):
         s += '_'
 

diff --git a/tests/test_astutil.py b/tests/test_astutil.py
@@ -3,6 +3,14 @@
 
 import comfy_script.astutil as astutil
 
+@pytest.mark.parametrize('s, id', [
+    (':<', '_'),
+    (':|', '_'),
+    (':/', '_'),
+])
+def test_str_to_raw_id(s, id):
+    assert astutil.str_to_raw_id(s) == id
+
 @pytest.mark.parametrize('s, c', [
     ('', "''"),
     ("'", "'''\\''''"),