Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop range-and-a-half algorithm overloads #323

Open
cjdb opened this issue Aug 14, 2019 · 1 comment
Open

Drop range-and-a-half algorithm overloads #323

cjdb opened this issue Aug 14, 2019 · 1 comment
Labels
bug

Comments

@cjdb
Copy link
Collaborator

cjdb commented Aug 14, 2019 •
edited
Loading

All of the input-range-and-a-half algorithms are deprecated in the Ranges TS, and MSVC doesn't recognise this flag.

We could add some fancy CMake to accommodate this, but these overloads aren't even in C++20 (unless I'm missing something). I think the solution is to drop the algorithms.
@cjdb cjdb added the bug label Aug 14, 2019
@cjdb cjdb changed the title -Wno-deprecated-warning isn't an MSVC warning -Wno-deprecated-declarations isn't an MSVC warning Aug 14, 2019
@CaseyCarter
Copy link
Owner

I'm having trouble connecting the issue title with the discussion to determine exactly what the problem is. I suspect you're not actually suggesting that we should add -Wno-deprecated-declarations to MSVC. 😉

@cjdb cjdb changed the title -Wno-deprecated-declarations isn't an MSVC warning Drop range-and-a-half algorithm overloads Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CaseyCarter @cjdb