Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad references for snapshots #5921

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix bad references for snapshots #5921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions forge-game/src/main/java/forge/game/GameSnapshot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,16 +362,16 @@ public void copyGameState(Game fromGame, Game toGame) {
if (fromCard.getCloneOrigin() != null) {
newCard.setCloneOrigin(toGame.findById(fromCard.getCloneOrigin().getId()));
}
if (newCard.getHaunting() != null) {
if (fromCard.getHaunting() != null) {
newCard.setHaunting(toGame.findById(fromCard.getHaunting().getId()));
}
if (newCard.getEffectSource() != null) {
if (fromCard.getEffectSource() != null) {
newCard.setEffectSource(toGame.findById(fromCard.getEffectSource().getId()));
}
if (newCard.isPaired()) {
if (fromCard.isPaired()) {
newCard.setPairedWith(toGame.findById(fromCard.getPairedWith().getId()));
}
if (newCard.getCopiedPermanent() != null) {
if (fromCard.getCopiedPermanent() != null) {
newCard.setCopiedPermanent(toGame.findById(fromCard.getCopiedPermanent().getId()));
}
// TODO: Verify that the above relationships are preserved bi-directionally or not.
Expand Down
1 change: 1 addition & 0 deletions forge-game/src/main/java/forge/game/card/CardCopyService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public final Card copyCard(boolean assignNewId, Player owner) {

// need to copy this values for the tokens
out.setTokenSpawningAbility(copyFrom.getTokenSpawningAbility());
out.setCopiedPermanent(copyFrom.getCopiedPermanent());
} else {
out = assignNewId ? getCard(copyFrom.getPaperCard(), owner, toGame)
: getCard(copyFrom.getPaperCard(), owner, copyFrom.getId(), toGame);
Expand Down
Loading