New cards (MKM) #4746
New cards (MKM) #4746
Conversation
Update paths_of_tuinvale.txt
Editing out
|
Whoever ends up merging this, can we make sure to squash and merge so we don't have 200 commits being added for 4 cards. |
|
One comment left open (in case you miss it) |
| SVar:DBForEach:DB$ RepeatEach | RepeatPlayers$ Player | RepeatSubAbility$ DBChoose | SubAbility$ DBDestroyAll | ||
| SVar:DBChoose:DB$ ChooseCard | Defined$ You | ChoiceZone$ Battlefield | Amount$ 1 | Choices$ Land.nonBasic+RememberedPlayerCtrl | Optional$ True | ImprintChosen$ True | ChoiceTitle$ Choose up to one nonbasic land this player controls. | ||
| SVar:DBDestroyAll:DB$ DestroyAll | ValidCards$ Land.nonBasic+IsImprinted | RememberLKI$ True | SubAbility$ DBSearch | ||
| SVar:DBSearch:DB$ ChangeZone | Origin$ Library | Destination$ Battlefield | Tapped$ True | ChangeType$ Land.Basic | ChangeNum$ 1 | RememberChanged$ True | DefinedPlayer$ ImprintedController | Optional$ True | SubAbility$ DBCleanup |
There was a problem hiding this comment.
why are you using ImprintedController here?
only RememberedController would have fewer (in case some were indestructible)
(the RememberChanged also does nothing)
There was a problem hiding this comment.
I'm using ImprintedController because I lifted a good deal of the script from From the Ashes. I imagine then that one also needs some updating. My tendency, navigating the code, likely unaware whether or not parameters are interchangeable, is to use what, given the name, seems to be the most relevant one.
(Forgot to remove RememberChanged even knowing it was setting up library shuffling. My bad on that one.)
There was a problem hiding this comment.
Just replaced ImprintedController with RememberedController to test it out and, on the selected lands being destroyed, I get no prompt to search my library for a land nor do tapped lands show up on my AI opponents' battlefields. I do vaguely recall this being an issue but I'm about 10 iterations deep on this script at this point.
There was a problem hiding this comment.
well RememberLKI doesn't exist on DestroyAll
so use RememberDestroyed
|
@dracontes you could try to make a "git rebase" too to skip the unwanted commits check "git rebase -i" to go into interactive mode, then you can "remove" the commits you don't want in this branch |
Having looked at my options, installing GitHub Desktop and Git Bash, I feel like I can squash commits confidently enough in the former. Otherwise, it'll definitely take me a while to figure things out, seeing as I've never used this software before. Unfortunately, the day job hasn't allowed me a whole lot time lately. |
|
Closing in lieu of #4764 |
Fair enough and much obliged for the quick resolution to this pickle :) |
|
Thanks for trying to push it forward though! |
Tested card scripts
*(MKM)*(MKM)*(MKM)Flare of Cultivation (MH3)†Snow-Covered Wastes (MH3)†*With an assist from Glorax's attempts at these cards.Minor Fixes
Updated Mythos of Snapdax to reflect the admittedly contrived possibility of a planeswalker also being a land.‡Fixed some inconsistent capitalization issues with a few parameters, always defaulting to the more common version.‡\editionsfile as recommended on Discord to disambiguate between its Red Herring and the MKM one.†Split off into #4754‡Split off into #4753