Compute coordinates only on dimensions of interest #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpadioleau
force-pushed
the
get-coords-on-dimensions-of-interest
branch
from
859523a to
8e4566f
Compare
|
@EmilyBourne I would like your opinion on this PR. What do you think ? |
EmilyBourne
approved these changes
Jan 6, 2025
I agree, it is on the todo list to remove this alias, it will be easier after this PR. |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the evaluation of coordinates in batch dimensions. The reason is that these dimensions don't need to be samplings, the related coordinates are actually ignored in the evaluator.
The batch dimensions are replaced by dummy dimensions that don't need to be initialised.