Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/webpack2 support #28

Merged
merged 3 commits into from
Jan 29, 2017

Conversation

hekike
Copy link
Contributor

@hekike hekike commented Jan 29, 2017

This PR continues the #22 by @ndelangen

The PR fixes the entrypoints for webpack2.
I tested this change with html-wepback-plugins and works well (needed a small fix there as well):
jantimon/html-webpack-plugin#569

@BohdanTkachenko what do you think can we ship a new beta from this PR?

@BohdanTkachenko
Copy link
Owner

It seems that webpack 2 has a stable version now - 2.2.0, so let's just merge this pull request to master branch and change major version to 2, so people will be able to still use old version for webpack1 and use new version for webpack2. And we can fix any upcoming issues when we face them.

What do you think, @hekike ?

@hekike
Copy link
Contributor Author

hekike commented Jan 29, 2017

@BohdanTkachenko sounds good to me!

@BohdanTkachenko BohdanTkachenko merged commit cb04ac3 into BohdanTkachenko:master Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants