perf: decouple item counting logic from data fetching #581
Conversation
🦋 Changeset detectedLatest commit: dc6188f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
==========================================
- Coverage 89.28% 89.27% -0.02%
==========================================
Files 150 150
Lines 9922 9922
Branches 1035 1033 -2
==========================================
- Hits 8859 8858 -1
- Misses 1063 1064 +1 ☔ View full report in Codecov by Sentry. |
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
283.8 KB (🟡 +38.18 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Pages Added
The following pages were added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/block_neighbor |
251 B |
284.04 KB | 81.15% |
/stats |
347.54 KB |
631.33 KB | 180.38% |
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/ |
351.83 KB |
635.63 KB | 181.61% (🟢 -5.00%) |
/address/[address] |
26.96 KB |
310.75 KB | 88.79% (🟢 -4.79%) |
/blob/[hash] |
27.63 KB |
311.42 KB | 88.98% (🟢 -4.23%) |
/blobs |
76.52 KB |
360.31 KB | 102.95% (🟡 +12.48%) |
/block/[id] |
14.31 KB |
298.11 KB | 85.17% (🟢 -4.15%) |
/blocks |
74.22 KB |
358.01 KB | 102.29% (🟡 +12.47%) |
/tx/[hash] |
16.31 KB |
300.11 KB | 85.75% (🟡 +0.87%) |
/txs |
73.72 KB |
357.52 KB | 102.15% (🟡 +10.46%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
… transactions on txs page
PJColombo
force-pushed
the
refactor/separate-items-counting-logic
branch
from
e9a20ac
to
dc6188f
Compare
* fix(api): set category filter to `ROLLUP` when the rollup filter is provided * feat(api): create blob `getCount` procedure * chore: add changeset * refactor(web): use `getCount()` procedure to retrieve total amount of blobs * chore: add changeset * feat(api): create block `getCount` procedure * chore: add changeset * fix(web): align header sleketon on blobs page view * refactor(web): use `getCount()` procedure to retrieve total amount of blocks * refactor(api): use count logic in `getAll` block procedure * feat(api): add transaction `getCount` procedure * refactor(web): use `getCount()` procedure to retrieve total amount of transactions on txs page * chore: merge changesets * refactor(web): organize query parameters by filter and pagination usage * test(api): remove rollup test
* fix(api): set category filter to `ROLLUP` when the rollup filter is provided * feat(api): create blob `getCount` procedure * chore: add changeset * refactor(web): use `getCount()` procedure to retrieve total amount of blobs * chore: add changeset * feat(api): create block `getCount` procedure * chore: add changeset * fix(web): align header sleketon on blobs page view * refactor(web): use `getCount()` procedure to retrieve total amount of blocks * refactor(api): use count logic in `getAll` block procedure * feat(api): add transaction `getCount` procedure * refactor(web): use `getCount()` procedure to retrieve total amount of transactions on txs page * chore: merge changesets * refactor(web): organize query parameters by filter and pagination usage * test(api): remove rollup test
* fix(api): set category filter to `ROLLUP` when the rollup filter is provided * feat(api): create blob `getCount` procedure * chore: add changeset * refactor(web): use `getCount()` procedure to retrieve total amount of blobs * chore: add changeset * feat(api): create block `getCount` procedure * chore: add changeset * fix(web): align header sleketon on blobs page view * refactor(web): use `getCount()` procedure to retrieve total amount of blocks * refactor(api): use count logic in `getAll` block procedure * feat(api): add transaction `getCount` procedure * refactor(web): use `getCount()` procedure to retrieve total amount of transactions on txs page * chore: merge changesets * refactor(web): organize query parameters by filter and pagination usage * test(api): remove rollup test
* fix(api): set category filter to `ROLLUP` when the rollup filter is provided * feat(api): create blob `getCount` procedure * chore: add changeset * refactor(web): use `getCount()` procedure to retrieve total amount of blobs * chore: add changeset * feat(api): create block `getCount` procedure * chore: add changeset * fix(web): align header sleketon on blobs page view * refactor(web): use `getCount()` procedure to retrieve total amount of blocks * refactor(api): use count logic in `getAll` block procedure * feat(api): add transaction `getCount` procedure * refactor(web): use `getCount()` procedure to retrieve total amount of transactions on txs page * chore: merge changesets * refactor(web): organize query parameters by filter and pagination usage * test(api): remove rollup test
Checklist
Description
IT BUILTS ON TOP PR #577
Resolves #572
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):