Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Testers/formatters refactoring #457

Merged
merged 56 commits into from
Mar 12, 2014
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
39de83f
Refactored testers in Testwork. Added setup routines
everzet Mar 5, 2014
3afc2f7
EventDispatcher extension provides dispatching testers
everzet Mar 5, 2014
854ebba
HookExtension listens to events produced by dispatch able testers
everzet Mar 5, 2014
e0aad1e
Pretty formatter is just an event listeners tree
everzet Mar 5, 2014
c11902d
Properly tearDown all event-dispatching testers
everzet Mar 6, 2014
1bdea54
StrictInterpretation::isFailure returns Boolean, not integer
everzet Mar 9, 2014
e989b91
SoftInterpretation implemented as a default result interpretation
everzet Mar 9, 2014
6f63483
TestResult refactored to be an interface
everzet Mar 9, 2014
dd6b0fd
Setup and Teardown VOs were introduced to handle test setUp and tearDown
everzet Mar 9, 2014
14c0fff
Hook scopes were introduced as a way to decouple hooks from events
everzet Mar 9, 2014
5642c62
Hook subsystem was refactored to use scopes instead of events
everzet Mar 9, 2014
023bf0b
Hookable testers are introduced
everzet Mar 9, 2014
c06bb0f
Event subsystem was refactored
everzet Mar 9, 2014
06076b6
Refactored Behat to support Testwork changes
everzet Mar 9, 2014
c122b65
Printer helpers are in the appropriate namespace
everzet Mar 9, 2014
baa5335
Removed unused hook listener
everzet Mar 9, 2014
f284512
Removed non-used printer arguments and fixed broken doc blocks
everzet Mar 9, 2014
dcf22f4
Implemented scenario hook printer
everzet Mar 9, 2014
1995d76
Implemented step hook printers
everzet Mar 9, 2014
cb4864d
Implemented example hooks printing
everzet Mar 9, 2014
81a4027
Fixed wrong event usage
everzet Mar 9, 2014
d65dd74
Do not dispatch hooks on skip
everzet Mar 9, 2014
bdfa226
Setup outside of scenario scope do not impact others
everzet Mar 9, 2014
16925fc
Print background step if its setup/teardown thrown exception
everzet Mar 9, 2014
6168d5c
Implemented printers for suite/feature hooks
everzet Mar 9, 2014
2f808e3
Implemented progress formatter
everzet Mar 9, 2014
aaaa200
Fixed fatal error in the statistics printer
everzet Mar 9, 2014
028235c
Fixed wrong path usage for the step stat
everzet Mar 9, 2014
af5fdca
Fixed result_types.feature
everzet Mar 9, 2014
4a25623
Fixed context.feature
everzet Mar 9, 2014
384fa96
Fixed error_reporting.feature and format_options.feature
everzet Mar 9, 2014
69a9fb0
Fixed hooks.feature
everzet Mar 10, 2014
7028c92
Fixed i18n.feature
everzet Mar 10, 2014
a990b95
Fixed broken case of empty suite
everzet Mar 10, 2014
c531625
Fixed multiple_formats.feature
everzet Mar 10, 2014
b2fd5a4
Collect error strings instead of exception objects in collection
everzet Mar 10, 2014
ee431f1
Properly handle backgrounds/scenarios and examples without titles
everzet Mar 10, 2014
51fb033
Ensure that SetUp and tearDown are always called. Event on --dry-run
everzet Mar 10, 2014
fe958a9
Print steps output with pretty formatter
everzet Mar 10, 2014
87dd909
Fixed dry_run.feature
everzet Mar 10, 2014
a8545ba
Refactored OnlyFirstBackgroundFiresListener by moving responsibilitie…
everzet Mar 10, 2014
3dffb25
Fixed ExerciseListener handling of pending steps
everzet Mar 10, 2014
16d6f5a
Fixed stop_on_failure.feature
everzet Mar 10, 2014
25e21b6
Fixed invalid multiple_formats.feature
everzet Mar 10, 2014
b6b71a4
Fixed name_filters.feature
everzet Mar 10, 2014
e478134
Fixed outlines.feature
everzet Mar 10, 2014
e7ca9bc
Fixed parameters.feature
everzet Mar 10, 2014
3d5f36f
Fixed pretty_format.feature
everzet Mar 10, 2014
428dca3
Fixed profiles.feature
everzet Mar 10, 2014
fbbe9ff
Fixed rerun.feature
everzet Mar 10, 2014
2758067
SigintController moved to EventDispatcher extension
everzet Mar 10, 2014
c9e03d1
Refactor Behat\ApplicationFactory a bit
everzet Mar 10, 2014
d795147
Added back support for Symfony 2.1, 2.2, 2.3
everzet Mar 10, 2014
2c37477
Clarify AfterStepTested method names
everzet Mar 11, 2014
60e9f5c
Moved ExceptionResult interface to a Testwork
everzet Mar 11, 2014
6d8b1b9
Simplified ExecutedStepResult::getException
everzet Mar 11, 2014
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unused hook listener
  • Loading branch information
everzet committed Mar 9, 2014
commit baa5335d8e9039d72eef6dbdbf20109c663cd91c

This file was deleted.

130 changes: 0 additions & 130 deletions src/Behat/Behat/Hook/Output/Node/Printer/Pretty/PrettyHookPrinter.php

This file was deleted.

17 changes: 0 additions & 17 deletions src/Behat/Behat/Hook/ServiceContainer/HookExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -86,21 +86,4 @@ protected function loadHookableTesters(ContainerBuilder $container)
$definition->addTag(TesterExtension::STEP_TESTER_WRAPPER_TAG, array('priority' => 9999));
$container->setDefinition(TesterExtension::STEP_TESTER_WRAPPER_TAG . '.hookable', $definition);
}

/**
* Loads output listeners.
*
* @param ContainerBuilder $container
*/
protected function loadOutputListeners(ContainerBuilder $container)
{
$definition = new Definition('Behat\Behat\Hook\Output\Node\EventListener\InPlaceHookListener', array(
new Reference(PrettyFormatterFactory::PRETTY_ROOT_LISTENER_ID),
new Definition('Behat\Behat\Hook\Output\Node\Printer\Pretty\PrettyHookPrinter', array(
new Reference(ExceptionExtension::PRESENTER_ID)
))
));
$definition->addTag(PrettyFormatterFactory::PRETTY_ROOT_LISTENER_WRAPPER_TAG);
$container->setDefinition(PrettyFormatterFactory::PRETTY_ROOT_LISTENER_WRAPPER_TAG . '.hooks', $definition);
}
}