Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number insight ga #47195

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

guoqing2023
Copy link
Member

@guoqing2023 guoqing2023 commented Nov 16, 2024

Packages impacted by this PR

@azure/communication-phone-numbers

Issues associated with this PR: https://skype.visualstudio.com/SPOOL/_workitems/edit/3994015/?view=edit

Describe the problem that is addressed by this PR

Number insight GA. No changes from public preview

Provide a list of related PRs (if any)

API Specs: Azure/azure-rest-api-specs#31978
.net: #47195
Java: Azure/azure-sdk-for-java#43290
Python: Azure/azure-sdk-for-python#38793
JavaScript: Azure/azure-sdk-for-js#32095

APIView:

API Specs: https://apiview.dev/Assemblies/Review/ba16371e7b7e46b79b9be65fa0119ccd?revisionId=484ad4a29e054ee1be1df31c6c45e2ba&diffOnly=False&doc=False&diffRevisionId=ba31920ba63c477597d96aded7f0e320
.net: https://spa.apiview.dev/review/e465f73b881e41a5875a9d614a96d3ad?activeApiRevisionId=ccea565c3a4542deacc389de5ca77f2d&diffApiRevisionId=26571e2b0fda4ccd88cf379b9cb06f61
Java: https://apiview.dev/Assemblies/Review/ef288c648931473f8ac61a2248b90b1a?revisionId=d2a2455731bd45b48e472cb0609352fb&diffOnly=False&doc=False&diffRevisionId=ce79f52fc3b64f2ab3e4329e49c5e3f2
Python: API changes are not detected in this pull request.
JavaScript: https://spa.apiview.dev/review/ec5503f48f0b42cdbbb2e6bd4ec0aa87?activeApiRevisionId=88cf3f64633b493eb88ef9db82ab425b&diffApiRevisionId=553e954e8cf34d79a9f4e67c6b649416

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 16, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Communication.PhoneNumbers

@guoqing2023 guoqing2023 force-pushed the guoqing/number-insight-ga branch from 49b6fad to f8b2ce1 Compare December 8, 2024 20:29
@guoqing2023 guoqing2023 requested review from jsquire and a team as code owners December 8, 2024 20:29
@guoqing2023 guoqing2023 force-pushed the guoqing/number-insight-ga branch from f8b2ce1 to ab8549c Compare December 8, 2024 21:03
jsquire
jsquire previously requested changes Dec 9, 2024
.gitignore Outdated
@@ -180,3 +180,5 @@ TempTypeSpecFiles/

# Common toolchain intermediate files
temp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not be making changes to root files. Please revert.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done

@guoqing2023 guoqing2023 force-pushed the guoqing/number-insight-ga branch 3 times, most recently from 5df4134 to d7fafb7 Compare December 26, 2024 04:24
@jsquire jsquire dismissed their stale review December 26, 2024 17:20

Root-level changes confirmed reverted.

@guoqing2023 guoqing2023 force-pushed the guoqing/number-insight-ga branch from 561e651 to b0e2b0d Compare January 1, 2025 17:05
@guoqing2023 guoqing2023 changed the title WIP: number insight ga number insight ga Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants