-
Notifications
You must be signed in to change notification settings - Fork 501
Allow backend.proxy parameterization #697
Allow backend.proxy parameterization #697
Conversation
Is it needed on all backend proxies, or just the logic apps ones? If a customer has two logic app flows (in different logic apps), is the backend proxy the same? |
@adrianhall, as I undestood from the discussion, clients wanted to have a As I see from the documentation of APIM API, we can not identify type of backend resource (view https://docs.microsoft.com/en-us/rest/api/apimanagement/current-ga/backend/get#backendcontract). So I can not determine, if backend resource is a logic app, and set proxy parametrization for it and in the other case just ignore So that is why I decided to put parametrization of What do you think? (sorry if I misunderstood the question) |
I'm not disagreeing with the approach just yet. Just asking the question about our API. Can the customer set a different proxy on each backend, or do they set a single proxy for all APIs. Your proposed solution is good for the latter and will cause issues in the former. |
I think they can set different proxy on each backend, because we can create 2 or more |
If that is the case, then I don't like this solution. Customers will use multiple logic apps so will have multiple proxies. |
It is hard to control the settings just using some console-boolean flags. So this User has to create a configuration for
This allows to specify anything you want really. Also I like that we will be declining exposing a lot of boolean flag console app arguments, which are very hard to maintain because of their amount. Configurations are always better in my opinion (more code to handle the flow, but much more maintainable and understandable). What do you think? |
Per discussion, we will extract the backend proxy without additional configuration (including no additional boolean command line arg - if backend parameterization is requested, then proxies will be parameterized too). We will determine which proxies are unique and provide a separate parameter for each unique proxy. Care to be taken around "what happens if we add a new proxy" to ensure that existing proxies continue to work with a parameter file. Perhaps by using the URL as part of the parameter name? |
I believe we can close this PR, to not take time in resolving conflicts, and change the approach here, PR: #787 introduced which includes agreed changes and ready for review |
Closing a PR due to another implementation in #787. Thanks, @f-alizada |
Added new console flag
--paramBackendProxy
. Flag set to true includes such a complex-object parameter in the output template file and sets the same settings to all of backend resources extracted.Closes #622