Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.12.10 #1594

Closed
wants to merge 2 commits into from

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jul 9, 2019

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.12.md#v11210

Issue Fixed:

Requirements:

  • Windows artifacts uploaded to acsmirror blob store
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:
This also updates ip-masq-agent version to v2.3.0 to fix vulnerabilities (kubernetes/kubernetes#77834) Already merged to master.

@acs-bot acs-bot added the size/M label Jul 9, 2019
@acs-bot
Copy link

acs-bot commented Jul 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #1594 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1594      +/-   ##
==========================================
+ Coverage   76.45%   76.49%   +0.04%     
==========================================
  Files         129      129              
  Lines       18996    18934      -62     
==========================================
- Hits        14523    14484      -39     
+ Misses       3681     3669      -12     
+ Partials      792      781      -11

@mboersma
Copy link
Member Author

mboersma commented Jul 9, 2019

/hold

We need to verify that #1421 is fixed before we can merge this. 🤞

@rjaini
Copy link
Contributor

rjaini commented Jul 12, 2019

@mboersma : Can you please add Azure Stack support as well with this PR. As 1.12.10 image on Azure stack is also available now.

@acs-bot acs-bot added size/M and removed size/XS labels Jul 12, 2019
@acs-bot acs-bot added size/XS and removed size/M labels Jul 12, 2019
@rjaini
Copy link
Contributor

rjaini commented Jul 12, 2019

@mboersma : Thanks for adding the Azs changes..

@mboersma
Copy link
Member Author

/joke

@mboersma
Copy link
Member Author

mboersma commented Aug 5, 2019

/help

@mboersma
Copy link
Member Author

mboersma commented Aug 5, 2019

/joke

@mboersma
Copy link
Member Author

mboersma commented Aug 5, 2019

/assign @serbrech

@mboersma
Copy link
Member Author

mboersma commented Aug 5, 2019

/cc @serbrech

@mboersma
Copy link
Member Author

mboersma commented Aug 5, 2019

/assign @CecileRobertMichon

@mboersma
Copy link
Member Author

mboersma commented Aug 5, 2019

/unassign @CecileRobertMichon

@mboersma
Copy link
Member Author

mboersma commented Aug 5, 2019

/meow

@acs-bot
Copy link

acs-bot commented Aug 5, 2019

@mboersma: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma mboersma deleted the add-k8s-1.12.10 branch November 22, 2019 21:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants