Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to SNI based authentication for aad app #3137

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Switching to SNI based authentication for aad app #3137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
339dd69
SNI auth
nagworld9 Jun 5, 2024
905f76b
new env var
nagworld9 Jun 5, 2024
423be8e
pylint
nagworld9 Jun 5, 2024
84a257d
Merge branch 'develop' into app-certs
nagworld9 Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
new env var
  • Loading branch information
@nagworld9
nagworld9 committed Jun 5, 2024
commit 905f76b56c3b77dd97681a801585cb4f5d2e6977
2 changes: 1 addition & 1 deletion tests_e2e/orchestrator/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ RUN \
cd $HOME && \
git clone https://github.com/microsoft/lisa.git && \
cd lisa && \
git checkout 2c16e32001fdefb9572dff61241451b648259dbf && \
git checkout 95c09ff7d5b6e71d1642a628607ac9bb441c69f5 && \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling lisa latest changes since they updated azure-identity version which supports SNI based authentication

\
python3 -m pip install --upgrade pip && \
python3 -m pip install --editable .[azure,libvirt] --config-settings editable_mode=compat && \
Expand Down
3 changes: 3 additions & 0 deletions tests_e2e/pipeline/scripts/execute_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ IP_ADDRESS=$(curl -4 ifconfig.io/ip)

# certificate location in the container
AZURE_CLIENT_CERTIFICATE_PATH="/home/waagent/app/cert.pem"
# Need to set this to True if we sue SNI based authentication for certificate
AZURE_CLIENT_SEND_CERTIFICATE_CHAIN="True"

docker run --rm \
--volume "$BUILD_SOURCESDIRECTORY:/home/waagent/WALinuxAgent" \
Expand All @@ -83,6 +85,7 @@ docker run --rm \
--env AZURE_CLIENT_ID \
--env AZURE_TENANT_ID \
--env AZURE_CLIENT_CERTIFICATE_PATH=$AZURE_CLIENT_CERTIFICATE_PATH \
--env AZURE_CLIENT_SEND_CERTIFICATE_CHAIN=$AZURE_CLIENT_SEND_CERTIFICATE_CHAIN \
waagenttests.azurecr.io/waagenttests \
bash --login -c \
"lisa \
Expand Down