Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Edit local batch account #2012

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Feature: Edit local batch account #2012

merged 2 commits into from
Apr 2, 2019

Conversation

timotheeguerin
Copy link
Member

fix #1951

@codecov
Copy link

codecov bot commented Apr 2, 2019 •
edited
Loading

Codecov Report

Merging #2012 into master will decrease coverage by 0.06%.
The diff coverage is 29.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2012      +/-   ##
=========================================
- Coverage   65.47%   65.4%   -0.07%     
=========================================
  Files        1035    1037       +2     
  Lines       28453   28485      +32     
  Branches     5072    5078       +6     
=========================================
+ Hits        18630   18632       +2     
- Misses       9807    9837      +30     
  Partials       16      16
Impacted Files Coverage Δ
...vices/batch-account/local-batch-account.service.ts 82.6% <0%> (-10.08%) ⬇️
.../app/components/account/action/account-commands.ts 32.43% <25%> (-15.85%) ⬇️
...t/action/add/edit-local-batch-account.component.ts 45.45% <45.45%> (ø)
...ty-commands-list/entity-commands-list.component.ts 71.42% <0%> (-28.58%) ⬇️
src/app/models/batch-account.ts 87.87% <0%> (-3.04%) ⬇️
.../@batch-flask/ui/entity-commands/entity-command.ts 50.4% <0%> (-1.61%) ⬇️
...nt/action/add/add-local-batch-account.component.ts 62.5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ad4a3...2ac78e6. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 03cf08e into master Apr 2, 2019
@timotheeguerin timotheeguerin deleted the feature/edit-local-batch-account branch April 2, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow updating local batch account properties
1 participant
@timotheeguerin