Skip to content

Commit

Permalink
Update Versions for 23.01 (nv-morpheus#242)
Browse files Browse the repository at this point in the history
Updates the necessary versions for 23.01. Biggest change is requirement for cmake 3.23.1 as required by RAPIDS Cmake 22.10.

Closes nv-morpheus#229

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Ryan Olson (https://github.com/ryanolson)
  - Devin Robison (https://github.com/drobison00)

URL: nv-morpheus#242
  • Loading branch information
mdemoret-nv authored Dec 13, 2022
1 parent 3c15683 commit 6817831
Show file tree
Hide file tree
Showing 11 changed files with 26 additions and 68 deletions.
10 changes: 5 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
cmake_minimum_required(VERSION 3.24 FATAL_ERROR)

list(APPEND CMAKE_MESSAGE_CONTEXT "mrc")

Expand All @@ -33,7 +33,7 @@ option(MRC_USE_CONDA "Enables finding dependencies via conda instead of vcpkg. N
option(MRC_USE_IWYU "Enable running include-what-you-use as part of the build process" OFF)
option(MRC_ENABLE_CODECOV "Enable gcov code coverage" OFF)

set(MRC_RAPIDS_VERSION "22.08" CACHE STRING "Which version of RAPIDS to build for. Sets default versions for RAPIDS CMake and RMM.")
set(MRC_RAPIDS_VERSION "22.10" CACHE STRING "Which version of RAPIDS to build for. Sets default versions for RAPIDS CMake and RMM.")

set(MRC_CACHE_DIR "${CMAKE_SOURCE_DIR}/.cache" CACHE PATH "Directory to contain all CPM and CCache data")
mark_as_advanced(MRC_CACHE_DIR)
Expand All @@ -49,16 +49,16 @@ enable_testing()
# Add the RAPIDS cmake helper scripts
include(cmake/import_rapids_cmake.cmake)

# Default to using "NATIVE" for CUDA_ARCHITECTURES to build based on GPU in system
# Default to using "native" (case-sensitive) for CUDA_ARCHITECTURES to build based on GPU in system
if(NOT DEFINED CMAKE_CUDA_ARCHITECTURES)
set(CMAKE_CUDA_ARCHITECTURES "NATIVE")
set(CMAKE_CUDA_ARCHITECTURES "native")
message(STATUS "CMAKE_CUDA_ARCHITECTURES was not defined. Defaulting to '${CMAKE_CUDA_ARCHITECTURES}' to build only for local architecture. Specify -DCMAKE_CUDA_ARCHITECTURES='ALL' to build for all archs.")
endif()

rapids_cuda_init_architectures(mrc)

project(mrc
VERSION 22.11.00
VERSION 23.01.00
LANGUAGES C CXX
)

Expand Down
6 changes: 3 additions & 3 deletions ci/conda/environments/dev_env.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dependencies:
- benchmark=1.6.0
- boost-cpp=1.74
- ccache
- cmake=3.22
- cmake=3.24
- cuda-nvml-dev=11.4
- cudatoolkit=11.4
- cython=0.29.24
Expand All @@ -24,11 +24,12 @@ dependencies:
- grpc-cpp=1.46
- gtest=1.10
- gxx_linux-64=11.2
- isort
- jinja2=3.0
- lcov=1.15
- libhwloc=2.5
- libprotobuf=3.20
- librmm=22.08
- librmm=22.10
- libtool
- ninja=1.10
- nlohmann_json=3.9
Expand All @@ -46,7 +47,6 @@ dependencies:
- pip:
- cython
- flake8
- isort
- numpy==1.21.2
- pytest
- pytest-timeout
Expand Down
6 changes: 3 additions & 3 deletions ci/conda/environments/dev_env_nogcc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dependencies:
- benchmark=1.6.0
- boost-cpp=1.74
- ccache
- cmake>=3.22
- cmake>=3.24
- cython=0.29.24
- doxygen=1.9.2
- flatbuffers=2.0
Expand All @@ -19,9 +19,10 @@ dependencies:
- graphviz=3.0
- grpc-cpp=1.46
- gtest=1.10
- isort
- libhwloc=2.5
- libprotobuf=3.20
- librmm=22.08
- librmm=22.10
- ninja=1.10
- nlohmann_json=3.9
- pkg-config=0.29
Expand All @@ -32,7 +33,6 @@ dependencies:
- pip:
- cython
- flake8
- isort
- pytest
- pytest-timeout
- yapf
10 changes: 6 additions & 4 deletions ci/conda/recipes/libmrc/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,29 +31,31 @@ python:

# Setup the dependencies to build with multiple versions of RAPIDS
rapids_version: # Keep around compatibility with current version -1
- 22.06
- 22.08
- 22.08
- 22.10


# Multiple versions of abseil are required to satisfy the solver for some
# environments. RAPIDS 22.06 only works with gRPC 1.45 and 22.08 only works with
# 1.46. For each version of gRPC, support 2 abseil versions. Zip all of the keys
# together to avoid impossible combinations
abseil_cpp:
- 20210324.2
- 20211102.0
- 20220623.0
- 20220623.0

grpc_cpp:
- 1.45
- 1.46
- 1.46
- 1.46

# UCX 1.12 is required for RAPIDS 22.06
ucx:
- 1.12
- 1.13
- 1.13
- 1.13


zip_keys:
- rapids_version
Expand Down
4 changes: 2 additions & 2 deletions ci/conda/recipes/libmrc/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ requirements:
- {{ compiler("cxx") }}
- autoconf >=2.69
- ccache
- cmake 3.22.*
- cmake >=3.24
- libtool
- ninja
- numactl-libs-cos7-x86_64
Expand Down Expand Up @@ -87,7 +87,7 @@ outputs:
- {{ compiler("c") }}
- {{ compiler("cuda") }}
- {{ compiler("cxx") }}
- cmake 3.22.*
- cmake >=3.24
- numactl-libs-cos7-x86_64
- sysroot_linux-64 2.17
host:
Expand Down
1 change: 0 additions & 1 deletion cmake/dependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ include(deps/Configure_prometheus)

# libcudacxx
# =========
set(LIBCUDACXX_VERSION "1.8.0" CACHE STRING "Version of libcudacxx to use")
include(deps/Configure_libcudacxx)

if(MRC_BUILD_BENCHMARKS)
Expand Down
4 changes: 2 additions & 2 deletions cmake/deps/Configure_libcudacxx.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# limitations under the License.
#=============================================================================

function(find_and_configure_libcudacxx version)
function(find_and_configure_libcudacxx)

list(APPEND CMAKE_MESSAGE_CONTEXT "libcudacxx")

Expand All @@ -35,4 +35,4 @@ function(find_and_configure_libcudacxx version)

endfunction()

find_and_configure_libcudacxx(${LIBCUDACXX_VERSION})
find_and_configure_libcudacxx()
43 changes: 0 additions & 43 deletions cmake/deps/Configure_taskflow.cmake

This file was deleted.

4 changes: 2 additions & 2 deletions docs/quickstart/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

list(APPEND CMAKE_MESSAGE_CONTEXT "quickstart")

cmake_minimum_required(VERSION 3.17 FATAL_ERROR)
cmake_minimum_required(VERSION 3.24 FATAL_ERROR)

# Add the Conda environment to the prefix path and add the CMake files
list(PREPEND CMAKE_PREFIX_PATH "$ENV{CONDA_PREFIX}")
Expand All @@ -25,7 +25,7 @@ list(PREPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/../../cmake")
include(import_rapids_cmake)

project(mrc-quickstart
VERSION 22.11.00
VERSION 23.01
LANGUAGES C CXX
)

Expand Down
4 changes: 2 additions & 2 deletions docs/quickstart/environment_cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ dependencies:
- graphviz=3.0
- gtest=1.10
- gxx_linux-64=11.2
- isort
- libtool
- ninja=1.10
- numactl-libs-cos7-x86_64
Expand All @@ -30,12 +31,11 @@ dependencies:
- python=3.8
- scikit-build>=0.12
- spdlog=1.8.5
- mrc=22.11
- mrc=23.01
- sysroot_linux-64=2.17
- pip:
- cython
- flake8
- isort
- numpy==1.21.2
- pytest
- pytest-timeout
Expand Down
2 changes: 1 addition & 1 deletion python/tests/test_module_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def test_contains():
def test_is_version_compatible():
registry = mrc.ModuleRegistry

release_version = [22, 11, 0]
release_version = [int(x) for x in mrc.__version__.split(".")]
old_release_version = [22, 10, 0]
no_version_patch = [22, 10]
no_version_minor_and_patch = [22]
Expand Down

0 comments on commit 6817831

Please sign in to comment.