Removing run_axelrod and factor/manager classes #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes 552 - Remove run_axelrod. - Removing manager, managerfactory and utils. - Removing corresponding tests. - Removing prebuilt cache argument from tournament. - Removing tutorial on command line. - Minor modifications to README.rst.
|
Have opened: Axelrod-Python/tournament#33 on the tournament repo to keep track of this. |
|
I'm happy with it. The drop in coverage seems mostly due to the plots not being made, so maybe we can add back some tests. I know it's hard to test plots other than just making them and checking that they don't crash. It may make sense now to move the plotting functionality into member functions of ResultsSet, but that can be another discussion. |
|
Don't merge, I'll add in those tests for the plots :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 552