Skip to content

Commit

Permalink
add an explanation around requeueing a bit
Browse files Browse the repository at this point in the history
  • Loading branch information
sanposhiho committed Oct 10, 2024
1 parent ad7d5dd commit 388e37e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion keps/sig-scheduling/4832-async-preemption/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ To achieve an asynchronous preemption, we will change the preemption plugin's im

Then, afterwards the preemption goroutine makes actual API calls to delete victime Pods and set `Pod.Status.NominatedNodeName`.
If the preemption goroutine fails at some point, it reverts the nomination via `AddNominatedPod` with [`clearNominatedNode`](https://github.com/kubernetes/kubernetes/blob/f5c538418189e119a8dbb60e2a2b22394548e326/pkg/scheduler/schedule_one.go#L135).
If the preemption goroutine succeeds, the Pod is queued back to the queue, and (hopefully) scheduled on the nominated node.

If the preemption goroutine is complete, the preemption plugin ungates the Pod;
the Pod is queued back to the queue with the Pod/delete event, and (hopefully) scheduled on the nominated node in the next scheduling cycle.

### Consideration to race condition

Expand Down

0 comments on commit 388e37e

Please sign in to comment.