-
Notifications
You must be signed in to change notification settings - Fork 36
PR Checklist
StefanJVA edited this page Jan 29, 2019
·
4 revisions
Before submitting a pull request, check these things:
- Code should compile (that includes the travis build)
- All warnings should be fixed or disabled with a pragma
- Test the code functionality (the code should produce the desired behavior on your machine)
- Apply autoformatting
- Make sure there are no conflicts between your branch and master
- Did you add new dependencies? Add them to the
.travis.yml
and announce them in slack. - Did you add new ROS topics or nodes? Document them here.
- Does your code follow the style guide?