ThreatsModal: Add bulk support #40692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents/threats-data-views-modal-integration
…omponents/threats-data-views-modal-integration
Protect: add HMR support Revert "Protect: add HMR support" This reverts commit 06497a0.
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
* Init project branch * Init project branch * Disable hiding of relevant fields * Remove custom name field handling for files, show type by default in list view * Init project branch --------- Co-authored-by: Nate Weller <hello@nateweller.com>
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors Protect: add HMR support Revert "Protect: add HMR support" This reverts commit 06497a0. * Protect: Refactor AdminSectionHero (#40516) * Restore history header * Pass status filter presets to consumer * Restore early return * Add plan level restrictions * Remove unneeded filter handling * Revert unnecessary threats data views updates * Fix import * Add size prop --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com>
* Init project branch * Protect: Refactor AdminSectionHero (#40516) * Restore history header * Pass status filter presets to consumer * Restore early return * Add plan level restrictions * Init project branch * Protect: Integrate ThreatsDataViews Component (#40076) * Separate scan and history DataViews * Reapply history routes * Add filters * Add toggle group control * Add historic flag * Update stories * Remove unneeded filter handling * Revert unnecessary threats data views updates * Fix import * Include fixer action as label in list view action dropdown * Add field constants * Reorg * Add initialFields prop, update active to current where applicable * Init project branch * Fix exports and imports * Move default values to function params * Fix ts warning * minor adjustment to definition of initial filters * Add tsc-expect-error to dummy arg for minification cases --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com>
* Init project branch * Init project branch * Improve component responsiveness * Init project branch * Fix merge conflict * Simplify, and only default to list view in mobile * Fix spacing * Minor adjustments to initialization of defaultLayouts, remove memo * Remove style overrides on core component * Reapply min-width for ScanToggleGroupControl --------- Co-authored-by: Nate Weller <hello@nateweller.com>
…to add/components/threats-modal-bulk-variation
Base automatically changed from
add/components/threats-data-views-modal-integration
to
add/protect/core
January 14, 2025 18:35
nateweller
force-pushed
the
add/protect/core
branch
from
3ac8f5d to
9044e90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the original
ThreatModalintegration (proposed here) to add support for handling bulk threats.Note: This addresses adding a modal for bulk fixer actions to align with that of the internal Protect alternative, however, we should consider a follow up task to add functionality to allow users so select any individual from the bulk list to view the individual threat details, proceed with actions, etc. Drafted up a potential solution for this here: #40720
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
ThreatsModalandThreatsDataViewsstorybooksScanResultsDataViewsinstance and displays when trigger theShow auto fixersactionScreenshots
Single threat:
Multiple threats:
