Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volta configuration for managing node versions #19705

Closed
wants to merge 4 commits into from
Closed

Add volta configuration for managing node versions #19705

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f7e5a9
Adds volta configuration to all package.json files
creativecoder Apr 29, 2021
4ee0e42
Adds changelog files
creativecoder Apr 29, 2021
d31f870
Use explicit versions rather than extends for packages
creativecoder Apr 29, 2021
35e4a18
Change significance to patch
creativecoder Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds changelog files
  • Loading branch information
@creativecoder
creativecoder committed Apr 29, 2021
commit 4ee0e42a22310bbcc545c39d1b797e16da4b5957
4 changes: 4 additions & 0 deletions projects/packages/connection-ui/changelog/add-volta-pin-node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not really "minor". It doesn't change the code at all, it's just configuring a dev tool.

Suggested change
Significance: minor
Significance: patch

Same in your other changelog files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Type: added

Added volta configuration to package.json to pin node version
4 changes: 4 additions & 0 deletions projects/packages/jitm/changelog/add-volta-pin-node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: added

Added volta configuration to package.json to pin node version
4 changes: 4 additions & 0 deletions projects/packages/lazy-images/changelog/add-volta-pin-node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: added

Added volta configuration to package.json to pin node version
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/add-volta-pin-node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: other

Added volta configuration to package.json to pin node version