Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly identify whether the server supports utf8mb4_520 #143

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dd32
Copy link
Member

@dd32 dd32 commented May 8, 2024

In older versions of PHP $db_version will be 5.5.5 for MariaDB, which prevents the use of the utf8mb4_unicode_520_ci collation.

See https://core.trac.wordpress.org/changeset/54384

This merges WordPress/wordpress-develop@fed98bd & WordPress/wordpress-develop@11df927 to HyperDB.

In older versions of PHP `$db_version` will be `5.5.5` for MariaDB, which prevents the use of the `utf8mb4_unicode_520_ci` collation.

See https://core.trac.wordpress.org/changeset/54384
@dd32
Copy link
Member Author

dd32 commented May 8, 2024

See WordPress/wordcamp.org#1310

Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants